You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ij...@apache.org on 2021/08/23 21:36:10 UTC

[kafka] branch 3.0 updated: KAFKA-12933: Flaky test ReassignPartitionsIntegrationTest.testReassignmentWithAlterIsrDisabled (#11244)

This is an automated email from the ASF dual-hosted git repository.

ijuma pushed a commit to branch 3.0
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/3.0 by this push:
     new 7dded7e  KAFKA-12933: Flaky test ReassignPartitionsIntegrationTest.testReassignmentWithAlterIsrDisabled (#11244)
7dded7e is described below

commit 7dded7edefb573f4300342a5ade8b689a4ca33d9
Author: David Mao <47...@users.noreply.github.com>
AuthorDate: Mon Aug 23 16:33:04 2021 -0500

    KAFKA-12933: Flaky test ReassignPartitionsIntegrationTest.testReassignmentWithAlterIsrDisabled (#11244)
    
    Removes assertion added in #10471. It's unsafe to assert that
    there are partition movements ongoing for some of the tests in
    the suite because partitions in some of the tests have 0 data,
    which may complete reassignment before `verify` can run.
    
    Tests pass locally.
    
    Reviewers: Luke Chen <sh...@gmail.com>, Ismael Juma <is...@juma.me.uk>
---
 .../integration/kafka/admin/ReassignPartitionsIntegrationTest.scala      | 1 -
 1 file changed, 1 deletion(-)

diff --git a/core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala b/core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala
index 490d177..55123f3 100644
--- a/core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala
+++ b/core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala
@@ -127,7 +127,6 @@ class ReassignPartitionsIntegrationTest extends ZooKeeperTestHarness {
     )
 
     val verifyAssignmentResult = runVerifyAssignment(cluster.adminClient, assignment, false)
-    assertTrue(verifyAssignmentResult.partsOngoing)
     assertFalse(verifyAssignmentResult.movesOngoing)
 
     // Wait for the assignment to complete