You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Gilles (JIRA)" <ji...@apache.org> on 2016/05/30 21:48:12 UTC
[jira] [Commented] (MATH-1370) Increase efficiency of
EnumeratedDistribution#probability
[ https://issues.apache.org/jira/browse/MATH-1370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15306968#comment-15306968 ]
Gilles commented on MATH-1370:
------------------------------
Thanks for the patch.
Is the additional unit test (in a new file) really necessary?
Does it test more than {{EnumeratedIntegerDistributionTest}}?
> Increase efficiency of EnumeratedDistribution#probability
> ---------------------------------------------------------
>
> Key: MATH-1370
> URL: https://issues.apache.org/jira/browse/MATH-1370
> Project: Commons Math
> Issue Type: Improvement
> Reporter: Ryan Gaffney
> Priority: Minor
> Labels: patch, performance
> Attachments: enum-distribution-perf-patch
>
>
> There are lots of other low hanging fruit in the distribution package but unfortunately this is the only one I got to that day.
> In the EnumeratedDistribution case, the probability() method is currently O(N) where N denotes number of random variables, even though the random variables are fixed / known. This change makes probability() O(1). The unlikely worst case scenario now consumes slightly more than 2x the memory, but I do not think this would be an issue in the vast majority of cases.
> Original PR (incorrectly against master) [here|https://github.com/apache/commons-math/pull/34].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)