[jira] Reopened: (WICKET-3119) Localizer cache does not include style in cache key when no component is given

["Nick Wiedenbrueck (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nick Wiedenbrueck reopened WICKET-3119:
---------------------------------------


That's the code when a component is given. I meant the code when no component is given (a couple of lines below that):

{code}
else
		{
			// locale is guaranteed to be != null
			cacheKey += "-" + locale.toString();
		}
{code}

> Localizer cache does not include style in cache key when no component is given
> ------------------------------------------------------------------------------
>
>                 Key: WICKET-3119
>                 URL: https://issues.apache.org/jira/browse/WICKET-3119
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>            Reporter: Nick Wiedenbrueck
>            Assignee: Igor Vaynberg
>         Attachments: localizer.patch
>
>
> Localizer uses a cache internally to cache the results of getString() methods. The getCacheKey() method creates the key for the cache entries:
> getCacheKey(final String key, final Component component, final Locale locale, final String style, final String variation)
> When a null component is given, this method creates a cache key from the key param and the locale param, but does not include the style param. When switching between styles, this leads to unexpected behavior.
> I'll attach a patch with test cases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.