You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Timur Alperovich <no...@github.com> on 2015/07/14 20:37:50 UTC

[jclouds] Move the delimiter/prefix tests to BaseContainerIntegrationTest (#810)

BaseContainerLiveTest is not run in every provider (notably file system API). The commit moves the test to BaseContainerIntegrationTest and updates the affected providers accordingly. We also shouldn't use the file separator character when testing the file system provider, as it will generate directories for every blob name of the form "foo/bar". This presents a challenge, since when we list the container, we will observe the directory entries (unlike in other providers). Using a "-" works around this issue.

The first commit adds an additional test for the case of two blobs "bar" and "bazar" with prefix set to "ba" and delimiter to "a". The test verifies the delimiter behavior in the case of a prefix ending with the delimiter character.
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/810

-- Commit Summary --

  * Add a test that sets delimiter and prefix.
  * Move tests to test the file system API.

-- File Changes --

    M apis/atmos/src/test/java/org/jclouds/atmos/blobstore/integration/AtmosContainerIntegrationLiveTest.java (10)
    M apis/atmos/src/test/java/org/jclouds/atmos/blobstore/integration/AtmosContainerLiveTest.java (11)
    M apis/swift/src/test/java/org/jclouds/openstack/swift/blobstore/integration/SwiftContainerLiveTest.java (11)
    M blobstore/src/test/java/org/jclouds/blobstore/integration/internal/BaseContainerIntegrationTest.java (55)
    M blobstore/src/test/java/org/jclouds/blobstore/integration/internal/BaseContainerLiveTest.java (57)
    M blobstore/src/test/java/org/jclouds/blobstore/strategy/internal/ListContainerTest.java (18)
    M providers/hpcloud-objectstorage/src/test/java/org/jclouds/hpcloud/objectstorage/blobstore/integration/HPCloudObjectStorageContainerIntegrationLiveTest.java (5)
    M providers/hpcloud-objectstorage/src/test/java/org/jclouds/hpcloud/objectstorage/blobstore/integration/HPCloudObjectStorageContainerLiveTest.java (6)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/810.patch
https://github.com/jclouds/jclouds/pull/810.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/810

Re: [jclouds] Move the delimiter/prefix tests to BaseContainerIntegrationTest (#810)

Posted by Timur Alperovich <no...@github.com>.
Closed #810.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/810#event-355742139

Re: [jclouds] Move the delimiter/prefix tests to BaseContainerIntegrationTest (#810)

Posted by Timur Alperovich <no...@github.com>.
Unfortunately, I need to squash the two PRs that amend the tests and the local blob store together. Closing this and opening a new one for all three commits together.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/810#issuecomment-121364261