You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "spmallette (via GitHub)" <gi...@apache.org> on 2026/07/25 20:07:09 UTC
[PR] Clarify group()-step callouts for non-productive key vs value projection [tinkerpop]
spmallette opened a new pull request, #3572:
URL: https://github.com/apache/tinkerpop/pull/3572
The two `group()`-step examples in `reference/the-traversal.asciidoc` that project `age` first as a key and then as a value were annotated with symmetric callouts, both saying the non-productive entries are "filtered". Their runtime behavior is actually asymmetric:
- A non-productive **key**-projection (`by('age').by('name')`) drops the vertex from the result map entirely — no key is produced for vertices lacking an `age` value.
- A non-productive **value**-projection (`by('name').by('age')`) keeps the key (since `name` is productive for every vertex) but leaves its value list empty, e.g. `ripple=[]`, `lop=[]`.
The old symmetric wording made the `{ripple:[], lop:[]}` output surprising. This change rewrites callout `<2>` to explain that keys are retained with empty value lists, and updates callout `<1>` to state the entry is dropped entirely, drawing an explicit contrast between the two cases. The `productive` cross-reference is preserved.
Only the two callouts changed; the example code lines are untouched and still render their live output at build time, which confirms the reworded prose matches what the reader sees.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clarify group()-step callouts for non-productive key vs value projection [tinkerpop]
Posted by "spmallette (via GitHub)" <gi...@apache.org>.
spmallette commented on PR #3572:
URL: https://github.com/apache/tinkerpop/pull/3572#issuecomment-5090618772
Merged with a031294e98da7554d641369b68f82c77fdc88211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clarify group()-step callouts for non-productive key vs value projection [tinkerpop]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3572:
URL: https://github.com/apache/tinkerpop/pull/3572#issuecomment-5080436692
## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/3572?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 79.99%. Comparing base ([`a28cd1f`](https://app.codecov.io/gh/apache/tinkerpop/commit/a28cd1f2f1f10c140030a56de44c5c6c045af5f0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89a62a9`](https://app.codecov.io/gh/apache/tinkerpop/commit/89a62a9836f66863e98cfc0a10ba6058d490d0d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 373 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3572 +/- ##
============================================
+ Coverage 76.35% 79.99% +3.63%
============================================
Files 1012 32 -980
Lines 60341 6914 -53427
Branches 7075 0 -7075
============================================
- Hits 46076 5531 -40545
+ Misses 11548 1057 -10491
+ Partials 2717 326 -2391
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/tinkerpop/pull/3572?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clarify group()-step callouts for non-productive key vs value projection [tinkerpop]
Posted by "spmallette (via GitHub)" <gi...@apache.org>.
spmallette closed pull request #3572: Clarify group()-step callouts for non-productive key vs value projection
URL: https://github.com/apache/tinkerpop/pull/3572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org