You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org> on 2008/06/27 02:04:45 UTC
[jira] Created: (TAPESTRY-2485) Stack frames in the exception
report are not always highlighted correctly
Stack frames in the exception report are not always highlighted correctly
-------------------------------------------------------------------------
Key: TAPESTRY-2485
URL: https://issues.apache.org/jira/browse/TAPESTRY-2485
Project: Tapestry
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.0.13
Reporter: Howard M. Lewis Ship
Priority: Minor
User code stack frames are supposed to be highlighted in blue (via adding a CSS class to the enclose <li>) but this doesn't always happen.
It appears the methods that are advised lose their line number information and this interferes the following code:
public String getFrameClass()
{
if (frame.getClassName().startsWith(appPackage) && frame.getLineNumber() > 0) return "t-usercode-frame";
return null;
}
The line number is 0 for the advised method.
Somehow we need to flag the method as user code, perhaps by finding a way to "re-attach" the line number from the advised method to its replacement.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Closed: (TAP5-20) Stack frames in the exception report are
not always highlighted correctly
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-20?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-20.
------------------------------------
Resolution: Fixed
Assignee: Howard M. Lewis Ship
Advising a method works by renaming the original method.
The original method keeps its line number information, and shows up correctly in the stack trace, except for the name (which is something like org.apache.tapestry5.integration.app1.pages.MethodAdviceDemo._$advised$setText.
The original method, setText() in this example, is fabricated on the fly and has no line number information.
Looking at the Javassist APIs, there doesn't seem to be a way to attach a LineNumberTable to a new method.
> Stack frames in the exception report are not always highlighted correctly
> -------------------------------------------------------------------------
>
> Key: TAP5-20
> URL: https://issues.apache.org/jira/browse/TAP5-20
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.1.0.0
> Reporter: Howard M. Lewis Ship
> Assignee: Howard M. Lewis Ship
> Priority: Minor
>
> User code stack frames are supposed to be highlighted in blue (via adding a CSS class to the enclose <li>) but this doesn't always happen.
> It appears the methods that are advised lose their line number information and this interferes the following code:
> public String getFrameClass()
> {
> if (frame.getClassName().startsWith(appPackage) && frame.getLineNumber() > 0) return "t-usercode-frame";
> return null;
> }
> The line number is 0 for the advised method.
> Somehow we need to flag the method as user code, perhaps by finding a way to "re-attach" the line number from the advised method to its replacement.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAP5-20) Stack frames in the exception report are
not always highlighted correctly
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-20?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-20:
-------------------------------------
Assignee: (was: Howard M. Lewis Ship)
Affects Version/s: (was: 5.0.15)
5.1.0.0
> Stack frames in the exception report are not always highlighted correctly
> -------------------------------------------------------------------------
>
> Key: TAP5-20
> URL: https://issues.apache.org/jira/browse/TAP5-20
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.1.0.0
> Reporter: Howard M. Lewis Ship
> Priority: Minor
>
> User code stack frames are supposed to be highlighted in blue (via adding a CSS class to the enclose <li>) but this doesn't always happen.
> It appears the methods that are advised lose their line number information and this interferes the following code:
> public String getFrameClass()
> {
> if (frame.getClassName().startsWith(appPackage) && frame.getLineNumber() > 0) return "t-usercode-frame";
> return null;
> }
> The line number is 0 for the advised method.
> Somehow we need to flag the method as user code, perhaps by finding a way to "re-attach" the line number from the advised method to its replacement.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Assigned: (TAP5-20) Stack frames in the exception report are
not always highlighted correctly
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-20?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reassigned TAP5-20:
----------------------------------------
Assignee: Howard M. Lewis Ship
> Stack frames in the exception report are not always highlighted correctly
> -------------------------------------------------------------------------
>
> Key: TAP5-20
> URL: https://issues.apache.org/jira/browse/TAP5-20
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.0.15
> Reporter: Howard M. Lewis Ship
> Assignee: Howard M. Lewis Ship
> Priority: Minor
>
> User code stack frames are supposed to be highlighted in blue (via adding a CSS class to the enclose <li>) but this doesn't always happen.
> It appears the methods that are advised lose their line number information and this interferes the following code:
> public String getFrameClass()
> {
> if (frame.getClassName().startsWith(appPackage) && frame.getLineNumber() > 0) return "t-usercode-frame";
> return null;
> }
> The line number is 0 for the advised method.
> Somehow we need to flag the method as user code, perhaps by finding a way to "re-attach" the line number from the advised method to its replacement.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Reopened: (TAP5-20) Stack frames in the exception report are
not always highlighted correctly
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-20?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reopened TAP5-20:
--------------------------------------
> Stack frames in the exception report are not always highlighted correctly
> -------------------------------------------------------------------------
>
> Key: TAP5-20
> URL: https://issues.apache.org/jira/browse/TAP5-20
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.1.0.0
> Reporter: Howard M. Lewis Ship
> Assignee: Howard M. Lewis Ship
> Priority: Minor
>
> User code stack frames are supposed to be highlighted in blue (via adding a CSS class to the enclose <li>) but this doesn't always happen.
> It appears the methods that are advised lose their line number information and this interferes the following code:
> public String getFrameClass()
> {
> if (frame.getClassName().startsWith(appPackage) && frame.getLineNumber() > 0) return "t-usercode-frame";
> return null;
> }
> The line number is 0 for the advised method.
> Somehow we need to flag the method as user code, perhaps by finding a way to "re-attach" the line number from the advised method to its replacement.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Closed: (TAP5-20) Stack frames in the exception report are
not always highlighted correctly
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-20?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-20.
------------------------------------
Resolution: Invalid
> Stack frames in the exception report are not always highlighted correctly
> -------------------------------------------------------------------------
>
> Key: TAP5-20
> URL: https://issues.apache.org/jira/browse/TAP5-20
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.1.0.0
> Reporter: Howard M. Lewis Ship
> Assignee: Howard M. Lewis Ship
> Priority: Minor
>
> User code stack frames are supposed to be highlighted in blue (via adding a CSS class to the enclose <li>) but this doesn't always happen.
> It appears the methods that are advised lose their line number information and this interferes the following code:
> public String getFrameClass()
> {
> if (frame.getClassName().startsWith(appPackage) && frame.getLineNumber() > 0) return "t-usercode-frame";
> return null;
> }
> The line number is 0 for the advised method.
> Somehow we need to flag the method as user code, perhaps by finding a way to "re-attach" the line number from the advised method to its replacement.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org