You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2012/02/01 23:58:15 UTC

DO NOT REPLY [Bug 52576] New: [PATCH] Change external file reference while preserving the formular itself

https://issues.apache.org/bugzilla/show_bug.cgi?id=52576

             Bug #: 52576
           Summary: [PATCH] Change external file reference while
                    preserving the formular itself
           Product: POI
           Version: 3.7
          Platform: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: HSSF
        AssignedTo: dev@poi.apache.org
        ReportedBy: cs.fra.community@sungard.com
    Classification: Unclassified


Created attachment 28249
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28249
changeExternalReference.patch - Patch to implement this feature

In our setup, we have a main XLS which references other (>10) XLS files.
The original author of the main XLS referenced some dummy files to create the
formulars in the main XLS.

During our program execution, we generate the "real" XLS files with should be
referenced by the main XLS.
The formular itself shouldn't be changed.


The attached patch introduces a new public method on HSSFWorkbook (As the OOXML
is completly different and not in our scope I skipped it).

This allows the caller to change the file reference while preserving the
formular itself.

As the file-notation is quite strange in the XLS lookup table I'm not 100% sure
wether all kind of absolute/relative paths are interpreted corretly.
I tested with
* Relative paths
* Absolute paths with windows drive letters
* Absolute paths with windows UNC path (\\server\share)

I have not signed any kind of NDA from Microsoft and used only the public
availible file format information.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


DO NOT REPLY [Bug 52576] [PATCH] Change external file reference while preserving the formular itself

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52576

SunGard Global Services Germany <cs...@sungard.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |PatchAvailable
         OS/Version|                            |All

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


DO NOT REPLY [Bug 52576] [PATCH] Change external file reference while preserving the formular itself

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52576

SunGard Global Services Germany <cs...@sungard.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28249|0                           |1
        is obsolete|                            |

--- Comment #1 from SunGard Global Services Germany <cs...@sungard.com> 2012-02-01 23:06:40 UTC ---
Created attachment 28250
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28250
changeExternalReference.patch - Patch to implement this feature

SVN diff patch

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


DO NOT REPLY [Bug 52576] [PATCH] Change external file reference while preserving the formular itself

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52576

SunGard Global Services Germany <cs...@sungard.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28250|0                           |1
        is obsolete|                            |

--- Comment #3 from SunGard Global Services Germany <cs...@sungard.com> 2012-02-07 22:09:21 UTC ---
Created attachment 28280
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28280
ChangeExternalReferenceWithTest.patch

Please find attached the patch applied against the latest SVN revision (trunk).

It includes the feature and unit tests for the user model and the internal
translation logic.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


DO NOT REPLY [Bug 52576] [PATCH] Change external file reference while preserving the formular itself

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52576

Yegor Kozlov <ye...@dinom.ru> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|49896                       |

--- Comment #2 from Yegor Kozlov <ye...@dinom.ru> 2012-02-03 10:14:51 UTC ---
Please provide unit tests, both low-level for SupBookRecord and usermodel-level
that involve calling HSSFWorkbook.changeExternalReference(). If the test
requires input workbooks then attach them too.

Regards,
Yegor

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


DO NOT REPLY [Bug 52576] [PATCH] Change external file reference while preserving the formular itself

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52576

Yegor Kozlov <ye...@dinom.ru> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Yegor Kozlov <ye...@dinom.ru> 2012-02-10 08:27:25 UTC ---
Thanks for the patch, applied in r1242701

Regards,
Yegor

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


DO NOT REPLY [Bug 52576] [PATCH] Change external file reference while preserving the formular itself

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52576

Yegor Kozlov <ye...@dinom.ru> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |49896

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org