[GitHub] [arrow] felipecrv commented on a diff in pull request #36431: GH-35511: [C++] Util: add memory_pool in `SwapEndianArrayData`

["felipecrv (via GitHub)" <gi...@apache.org>]

felipecrv commented on code in PR #36431:
URL: https://github.com/apache/arrow/pull/36431#discussion_r1252259771


##########
cpp/src/arrow/array/util.cc:
##########
@@ -296,11 +301,14 @@ class ArrayDataEndianSwapper {
 namespace internal {
 
 Result<std::shared_ptr<ArrayData>> SwapEndianArrayData(
-    const std::shared_ptr<ArrayData>& data) {
+    const std::shared_ptr<ArrayData>& data, MemoryPool* pool) {
   if (data->offset != 0) {
     return Status::Invalid("Unsupported data format: data.offset != 0");
   }
-  ArrayDataEndianSwapper swapper(data);
+  if (pool == nullptr) {
+    return Status::Invalid("Unsupported pool == nullptr");
+  }

Review Comment:
   This being an internal API, should we even have this validation?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org