You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/04/26 14:47:05 UTC
[GitHub] [orc] boroknagyz opened a new pull request #691: ORC-790: TIMESTAMP_INSTANT should be primitive
boroknagyz opened a new pull request #691:
URL: https://github.com/apache/orc/pull/691
This patch makes TIMESTAMP_INSTANT a primitive type.
<!--
Thanks for sending a pull request! Here are some tips for you:
1. File a JIRA issue first and use it as a prefix of your PR title, e.g., `ORC-001: Fix ABC`.
2. Use your PR title to summarize what this PR proposes instead of describing the problem.
3. Make PR title and description complete because these will be the permanent commit log.
4. If possible, provide a concise and reproducible example to reproduce the issue for a faster review.
5. If the PR is unfinished, use GitHub PR Draft feature.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a change in pull request #691: ORC-790: TIMESTAMP_INSTANT should be primitive
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #691:
URL: https://github.com/apache/orc/pull/691#discussion_r620391355
##########
File path: java/core/src/java/org/apache/orc/TypeDescription.java
##########
@@ -116,7 +116,7 @@ public int compareTo(TypeDescription other) {
MAP("map", false),
STRUCT("struct", false),
UNION("uniontype", false),
- TIMESTAMP_INSTANT("timestamp with local time zone", false);
+ TIMESTAMP_INSTANT("timestamp with local time zone", true);
Review comment:
cc @omalley since this is ORC-189.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a change in pull request #691: ORC-790: TIMESTAMP_INSTANT should be primitive
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #691:
URL: https://github.com/apache/orc/pull/691#discussion_r620391972
##########
File path: java/core/src/java/org/apache/orc/TypeDescription.java
##########
@@ -116,7 +116,7 @@ public int compareTo(TypeDescription other) {
MAP("map", false),
STRUCT("struct", false),
UNION("uniontype", false),
- TIMESTAMP_INSTANT("timestamp with local time zone", false);
+ TIMESTAMP_INSTANT("timestamp with local time zone", true);
Review comment:
Also, cc @prasanthj , @wgtmac , @williamhyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] omalley merged pull request #691: ORC-790: TIMESTAMP_INSTANT should be primitive
Posted by GitBox <gi...@apache.org>.
omalley merged pull request #691:
URL: https://github.com/apache/orc/pull/691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #691: ORC-790: TIMESTAMP_INSTANT should be primitive
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #691:
URL: https://github.com/apache/orc/pull/691#issuecomment-828737429
Thank you, @boroknagyz and @omalley !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org