You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "jdaugherty (via GitHub)" <gi...@apache.org> on 2026/01/17 19:47:13 UTC
[PR] #15321 - Disable Invoke Dynamic by Default [grails-core]
jdaugherty opened a new pull request, #15322:
URL: https://github.com/apache/grails-core/pull/15322
Fixes https://github.com/apache/grails-core/issues/15321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #15321 - Disable Invoke Dynamic by Default [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty merged PR #15322:
URL: https://github.com/apache/grails-core/pull/15322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #15321 - Disable Invoke Dynamic by Default [grails-core]
Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley commented on code in PR #15322:
URL: https://github.com/apache/grails-core/pull/15322#discussion_r2701850542
##########
grails-doc/src/en/guide/upgrading/upgrading60x.adoc:
##########
@@ -62,7 +61,7 @@ In your gradle file, you can force a dependency upgrade via this code:
}
----
-5. By default, Groovy 4 switches away from callsite optimizations and uses invokedynamic instead. This can result in performance regressions compared to Grails 6. Groovy 5 will remove the ability to disable invokedynamic, but to disable it for Groovy 4, modify your `build.gradle` to include the following:
+* By default, Groovy 4 switches away from callsite optimizations and uses invokedynamic instead. This can result in performance regressions compared to Grails 6. Groovy 5 will remove the ability to disable invokedynamic, but to disable it for Groovy 4, modify your `build.gradle` to include the following:
Review Comment:
The other numbers were converted to *, except for 6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #15321 - Disable Invoke Dynamic by Default [grails-core]
Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley commented on code in PR #15322:
URL: https://github.com/apache/grails-core/pull/15322#discussion_r2705090617
##########
grails-doc/src/en/guide/upgrading/upgrading60x.adoc:
##########
@@ -62,7 +61,7 @@ In your gradle file, you can force a dependency upgrade via this code:
}
----
-5. By default, Groovy 4 switches away from callsite optimizations and uses invokedynamic instead. This can result in performance regressions compared to Grails 6. Groovy 5 will remove the ability to disable invokedynamic, but to disable it for Groovy 4, modify your `build.gradle` to include the following:
+* By default, Groovy 4 switches away from callsite optimizations and uses invokedynamic instead. This can result in performance regressions compared to Grails 6. Groovy 5 will remove the ability to disable invokedynamic, but to disable it for Groovy 4, modify your `build.gradle` to include the following:
Review Comment:
You are correct, it was just the way the line wrapped on the PR. Sorry for the false alarm. Looked at it too quickly.
<img width="1352" height="240" alt="Image" src="https://github.com/user-attachments/assets/3ec1bac2-7da1-4e43-ad3e-0c663a923482" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #15321 - Disable Invoke Dynamic by Default [grails-core]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #15322:
URL: https://github.com/apache/grails-core/pull/15322#issuecomment-3764490785
<!-- Bito Reply -->
The diff indicates that numbered list items 1-5 in the upgrading guide were converted to bullet points (*), but no item 6 is visible in the changes. This might be intentional or an oversight if a 6th item exists elsewhere in the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #15321 - Disable Invoke Dynamic by Default [grails-core]
Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley commented on code in PR #15322:
URL: https://github.com/apache/grails-core/pull/15322#discussion_r2701850542
##########
grails-doc/src/en/guide/upgrading/upgrading60x.adoc:
##########
@@ -62,7 +61,7 @@ In your gradle file, you can force a dependency upgrade via this code:
}
----
-5. By default, Groovy 4 switches away from callsite optimizations and uses invokedynamic instead. This can result in performance regressions compared to Grails 6. Groovy 5 will remove the ability to disable invokedynamic, but to disable it for Groovy 4, modify your `build.gradle` to include the following:
+* By default, Groovy 4 switches away from callsite optimizations and uses invokedynamic instead. This can result in performance regressions compared to Grails 6. Groovy 5 will remove the ability to disable invokedynamic, but to disable it for Groovy 4, modify your `build.gradle` to include the following:
Review Comment:
The other numbers where converted to *, except for 6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #15321 - Disable Invoke Dynamic by Default [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on code in PR #15322:
URL: https://github.com/apache/grails-core/pull/15322#discussion_r2705075274
##########
grails-doc/src/en/guide/upgrading/upgrading60x.adoc:
##########
@@ -62,7 +61,7 @@ In your gradle file, you can force a dependency upgrade via this code:
}
----
-5. By default, Groovy 4 switches away from callsite optimizations and uses invokedynamic instead. This can result in performance regressions compared to Grails 6. Groovy 5 will remove the ability to disable invokedynamic, but to disable it for Groovy 4, modify your `build.gradle` to include the following:
+* By default, Groovy 4 switches away from callsite optimizations and uses invokedynamic instead. This can result in performance regressions compared to Grails 6. Groovy 5 will remove the ability to disable invokedynamic, but to disable it for Groovy 4, modify your `build.gradle` to include the following:
Review Comment:
Before the numbering was resetting:
<img width="1577" height="786" alt="Image" src="https://github.com/user-attachments/assets/8db1fb65-4411-443e-8915-9ab4147dbbe2" />
But now it looks like this:
<img width="720" height="664" alt="Image" src="https://github.com/user-attachments/assets/f9eae93c-3acc-4ef3-bf35-5b94b5e3fad2" />
I don't see a 6th option that is a number. I'm going to proceed with merging and address this if you see otherwise ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org