You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@abdera.apache.org by ca...@apache.org on 2008/06/20 08:46:56 UTC

svn commit: r669801 - in /incubator/abdera/java/trunk: pom.xml server/src/test/java/org/apache/abdera/protocol/server/test/basic/BasicTest.java server/src/test/java/org/apache/abdera/protocol/server/test/custom/CustomProviderTest.java

Author: calavera
Date: Thu Jun 19 23:46:56 2008
New Revision: 669801

URL: http://svn.apache.org/viewvc?rev=669801&view=rev
Log:
fixes ABDERA-176, ABDERA-177, ABDERA-178

Modified:
    incubator/abdera/java/trunk/pom.xml
    incubator/abdera/java/trunk/server/src/test/java/org/apache/abdera/protocol/server/test/basic/BasicTest.java
    incubator/abdera/java/trunk/server/src/test/java/org/apache/abdera/protocol/server/test/custom/CustomProviderTest.java

Modified: incubator/abdera/java/trunk/pom.xml
URL: http://svn.apache.org/viewvc/incubator/abdera/java/trunk/pom.xml?rev=669801&r1=669800&r2=669801&view=diff
==============================================================================
--- incubator/abdera/java/trunk/pom.xml (original)
+++ incubator/abdera/java/trunk/pom.xml Thu Jun 19 23:46:56 2008
@@ -251,7 +251,8 @@
   					<configuration>
   						<excludes>
   							<exclude>**/*TestSuite*</exclude>
-  							<exclude>**/*$Test*</exclude>
+  							<exclude>**/*$*</exclude>
+  							<exclude>**/*TestAdapter*</exclude>
   							<exclude>**/FeedValidatorTest.java</exclude>
   							<exclude>**/DSigThirdPartyVerifyTest.java</exclude>
   							<exclude>**/AtomConformanceTest.java</exclude>

Modified: incubator/abdera/java/trunk/server/src/test/java/org/apache/abdera/protocol/server/test/basic/BasicTest.java
URL: http://svn.apache.org/viewvc/incubator/abdera/java/trunk/server/src/test/java/org/apache/abdera/protocol/server/test/basic/BasicTest.java?rev=669801&r1=669800&r2=669801&view=diff
==============================================================================
--- incubator/abdera/java/trunk/server/src/test/java/org/apache/abdera/protocol/server/test/basic/BasicTest.java (original)
+++ incubator/abdera/java/trunk/server/src/test/java/org/apache/abdera/protocol/server/test/basic/BasicTest.java Thu Jun 19 23:46:56 2008
@@ -130,7 +130,7 @@
     options.setContentType("application/octet-stream");
     ClientResponse resp = client.post("http://localhost:9002/sample", in, options);
     assertEquals(resp.getType(), ResponseType.CLIENT_ERROR);
-    assertEquals(resp.getStatus(), 415);
+    assertEquals(resp.getStatus(), 405);
     resp.release();
   }
   @Test

Modified: incubator/abdera/java/trunk/server/src/test/java/org/apache/abdera/protocol/server/test/custom/CustomProviderTest.java
URL: http://svn.apache.org/viewvc/incubator/abdera/java/trunk/server/src/test/java/org/apache/abdera/protocol/server/test/custom/CustomProviderTest.java?rev=669801&r1=669800&r2=669801&view=diff
==============================================================================
--- incubator/abdera/java/trunk/server/src/test/java/org/apache/abdera/protocol/server/test/custom/CustomProviderTest.java (original)
+++ incubator/abdera/java/trunk/server/src/test/java/org/apache/abdera/protocol/server/test/custom/CustomProviderTest.java Thu Jun 19 23:46:56 2008
@@ -153,7 +153,7 @@
     options.setContentType("application/octet-stream");
     ClientResponse resp = client.post(BASE + "/feed", in, options);
     assertEquals(resp.getType(), ResponseType.CLIENT_ERROR);
-    assertEquals(resp.getStatus(), 415);
+    assertEquals(resp.getStatus(), 405);
     resp.release();
   }
 



Re: svn commit: r669801 - in /incubator/abdera/java/trunk: pom.xml server/src/test/java/org/apache/abdera/protocol/server/test/basic/BasicTest.java server/src/test/java/org/apache/abdera/protocol/server/test/custom/CustomProviderTest.java

Posted by David Calavera <da...@gmail.com>.
Sure, I'm sorry, I'm taking it in account since now.

On Fri, Jun 20, 2008 at 3:33 PM, Garrett Rooney <
rooneg@electricjellyfish.net> wrote:

> On Fri, Jun 20, 2008 at 2:46 AM,  <ca...@apache.org> wrote:
> > Author: calavera
> > Date: Thu Jun 19 23:46:56 2008
> > New Revision: 669801
> >
> > URL: http://svn.apache.org/viewvc?rev=669801&view=rev
> > Log:
> > fixes ABDERA-176, ABDERA-177, ABDERA-178
>
> In the future could you please include a short description of what the
> bugs were about?  Looking through a log and just seeing issue numbers
> is really less than informative, it means you have to go look
> someplace else to see exactly what was being fixed.  Also, I don't
> know about these particular issues, but if they had patches submitted
> by someone other than you then the log message should credit the
> authors.
>
> -garrett
>

Re: svn commit: r669801 - in /incubator/abdera/java/trunk: pom.xml server/src/test/java/org/apache/abdera/protocol/server/test/basic/BasicTest.java server/src/test/java/org/apache/abdera/protocol/server/test/custom/CustomProviderTest.java

Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On Fri, Jun 20, 2008 at 2:46 AM,  <ca...@apache.org> wrote:
> Author: calavera
> Date: Thu Jun 19 23:46:56 2008
> New Revision: 669801
>
> URL: http://svn.apache.org/viewvc?rev=669801&view=rev
> Log:
> fixes ABDERA-176, ABDERA-177, ABDERA-178

In the future could you please include a short description of what the
bugs were about?  Looking through a log and just seeing issue numbers
is really less than informative, it means you have to go look
someplace else to see exactly what was being fixed.  Also, I don't
know about these particular issues, but if they had patches submitted
by someone other than you then the log message should credit the
authors.

-garrett