You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Svetlin Zarev <sv...@gmail.com> on 2017/07/03 09:44:58 UTC
Removing ANT from the packaged tomee distributions
Hi everyone!
Recently CGLIB was added as a dependency to TomEE (commit id: 703e9770),
and in turn it brought Apache Ant as "compile" dependency. Yet it's not
used by cglib at runtime, so it shouldn't really be packaged in the final
assembly.
What do you think about excluding it from the packaged TomEE distributions
?
Kind regards,
Svetlin
Re: Removing ANT from the packaged tomee distributions
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Hi Svetlin,
would need to check the dependency tree but cglib can miss a
<scope>test</scope>. We shouldnt have cglib at runtime at all
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://blog-rmannibucau.rhcloud.com> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory
<https://javaeefactory-rmannibucau.rhcloud.com>
2017-07-03 11:44 GMT+02:00 Svetlin Zarev <sv...@gmail.com>:
> Hi everyone!
>
> Recently CGLIB was added as a dependency to TomEE (commit id: 703e9770),
> and in turn it brought Apache Ant as "compile" dependency. Yet it's not
> used by cglib at runtime, so it shouldn't really be packaged in the final
> assembly.
>
> What do you think about excluding it from the packaged TomEE distributions
> ?
>
> Kind regards,
> Svetlin
>
Re: Removing ANT from the packaged tomee distributions
Posted by Jonathan Gallimore <jg...@tomitribe.com>.
+1, many thanks for the patch!
Jon
On Mon, Jul 3, 2017 at 1:36 PM, Jean-Louis Monteiro <
jlmonteiro@tomitribe.com> wrote:
> it looks good to me too. I'll merge it if everyone is happy with it
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
> On Mon, Jul 3, 2017 at 2:05 PM, Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
> > +1 to merge the PR short term to avoid this dep issue (originally issue
> > came from the JVM support of the default old cglib transitive dep of
> rmock)
> >
> > long term +1 to drop mock usage on
> > https://github.com/apache/tomee/blob/8fc8d8011c5155e7f47ebc162cb881
> > 24bf4ca06e/server/openejb-ejbd/src/test/java/org/apache/
> > openejb/server/ejbd/BasicClusterableRequestHandlerTest.java
> > - i don't see what mocks brings except potentially a false positive test
> >
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > <https://blog-rmannibucau.rhcloud.com> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <https://github.com/
> > rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory
> > <https://javaeefactory-rmannibucau.rhcloud.com>
> >
> > 2017-07-03 14:01 GMT+02:00 Svetlin Zarev <svetlin.angelov.zarev@gmail.
> com
> > >:
> >
> > > Thanks!
> > >
> > > Some additional info:
> > > * cglib and its dependencies(ant, asm) were added to openejb-ejbd and
> > hence
> > > into tomee
> > > * openejb-ejbd does not have imports to cglib classes
> > > * without csglib a single test fail because of ClassNotFound in RMock
> > >
> > > So as Romain suggested it seems to be a missed "test" scope.
> > > Here is the PR: https://github.com/apache/tomee/pull/82
> > >
> > > Bets regards,
> > > Svetlin
> > >
> > >
> > >
> > > 2017-07-03 14:09 GMT+03:00 Jean-Louis Monteiro <
> jlmonteiro@tomitribe.com
> > >:
> > >
> > > > If not needed I'm totally ok.
> > > > Can you submit a PR?
> > > > I'dbe happy to merge it for you
> > > >
> > > >
> > > > Le 3 juil. 2017 11:45, "Svetlin Zarev" <svetlin.angelov.zarev@gmail.
> > com>
> > > a
> > > > écrit :
> > > >
> > > > > Hi everyone!
> > > > >
> > > > > Recently CGLIB was added as a dependency to TomEE (commit id:
> > > 703e9770),
> > > > > and in turn it brought Apache Ant as "compile" dependency. Yet it's
> > not
> > > > > used by cglib at runtime, so it shouldn't really be packaged in the
> > > final
> > > > > assembly.
> > > > >
> > > > > What do you think about excluding it from the packaged TomEE
> > > > distributions
> > > > > ?
> > > > >
> > > > > Kind regards,
> > > > > Svetlin
> > > > >
> > > >
> > >
> >
>
--
Jonathan Gallimore
http://twitter.com/jongallimore
http://www.tomitribe.com
Re: Removing ANT from the packaged tomee distributions
Posted by Jean-Louis Monteiro <jl...@tomitribe.com>.
it looks good to me too. I'll merge it if everyone is happy with it
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Mon, Jul 3, 2017 at 2:05 PM, Romain Manni-Bucau <rm...@gmail.com>
wrote:
> +1 to merge the PR short term to avoid this dep issue (originally issue
> came from the JVM support of the default old cglib transitive dep of rmock)
>
> long term +1 to drop mock usage on
> https://github.com/apache/tomee/blob/8fc8d8011c5155e7f47ebc162cb881
> 24bf4ca06e/server/openejb-ejbd/src/test/java/org/apache/
> openejb/server/ejbd/BasicClusterableRequestHandlerTest.java
> - i don't see what mocks brings except potentially a false positive test
>
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> <https://blog-rmannibucau.rhcloud.com> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <https://github.com/
> rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory
> <https://javaeefactory-rmannibucau.rhcloud.com>
>
> 2017-07-03 14:01 GMT+02:00 Svetlin Zarev <svetlin.angelov.zarev@gmail.com
> >:
>
> > Thanks!
> >
> > Some additional info:
> > * cglib and its dependencies(ant, asm) were added to openejb-ejbd and
> hence
> > into tomee
> > * openejb-ejbd does not have imports to cglib classes
> > * without csglib a single test fail because of ClassNotFound in RMock
> >
> > So as Romain suggested it seems to be a missed "test" scope.
> > Here is the PR: https://github.com/apache/tomee/pull/82
> >
> > Bets regards,
> > Svetlin
> >
> >
> >
> > 2017-07-03 14:09 GMT+03:00 Jean-Louis Monteiro <jlmonteiro@tomitribe.com
> >:
> >
> > > If not needed I'm totally ok.
> > > Can you submit a PR?
> > > I'dbe happy to merge it for you
> > >
> > >
> > > Le 3 juil. 2017 11:45, "Svetlin Zarev" <svetlin.angelov.zarev@gmail.
> com>
> > a
> > > écrit :
> > >
> > > > Hi everyone!
> > > >
> > > > Recently CGLIB was added as a dependency to TomEE (commit id:
> > 703e9770),
> > > > and in turn it brought Apache Ant as "compile" dependency. Yet it's
> not
> > > > used by cglib at runtime, so it shouldn't really be packaged in the
> > final
> > > > assembly.
> > > >
> > > > What do you think about excluding it from the packaged TomEE
> > > distributions
> > > > ?
> > > >
> > > > Kind regards,
> > > > Svetlin
> > > >
> > >
> >
>
Re: Removing ANT from the packaged tomee distributions
Posted by Romain Manni-Bucau <rm...@gmail.com>.
+1 to merge the PR short term to avoid this dep issue (originally issue
came from the JVM support of the default old cglib transitive dep of rmock)
long term +1 to drop mock usage on
https://github.com/apache/tomee/blob/8fc8d8011c5155e7f47ebc162cb88124bf4ca06e/server/openejb-ejbd/src/test/java/org/apache/openejb/server/ejbd/BasicClusterableRequestHandlerTest.java
- i don't see what mocks brings except potentially a false positive test
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://blog-rmannibucau.rhcloud.com> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory
<https://javaeefactory-rmannibucau.rhcloud.com>
2017-07-03 14:01 GMT+02:00 Svetlin Zarev <sv...@gmail.com>:
> Thanks!
>
> Some additional info:
> * cglib and its dependencies(ant, asm) were added to openejb-ejbd and hence
> into tomee
> * openejb-ejbd does not have imports to cglib classes
> * without csglib a single test fail because of ClassNotFound in RMock
>
> So as Romain suggested it seems to be a missed "test" scope.
> Here is the PR: https://github.com/apache/tomee/pull/82
>
> Bets regards,
> Svetlin
>
>
>
> 2017-07-03 14:09 GMT+03:00 Jean-Louis Monteiro <jl...@tomitribe.com>:
>
> > If not needed I'm totally ok.
> > Can you submit a PR?
> > I'dbe happy to merge it for you
> >
> >
> > Le 3 juil. 2017 11:45, "Svetlin Zarev" <sv...@gmail.com>
> a
> > écrit :
> >
> > > Hi everyone!
> > >
> > > Recently CGLIB was added as a dependency to TomEE (commit id:
> 703e9770),
> > > and in turn it brought Apache Ant as "compile" dependency. Yet it's not
> > > used by cglib at runtime, so it shouldn't really be packaged in the
> final
> > > assembly.
> > >
> > > What do you think about excluding it from the packaged TomEE
> > distributions
> > > ?
> > >
> > > Kind regards,
> > > Svetlin
> > >
> >
>
Re: Removing ANT from the packaged tomee distributions
Posted by Svetlin Zarev <sv...@gmail.com>.
Thanks!
Some additional info:
* cglib and its dependencies(ant, asm) were added to openejb-ejbd and hence
into tomee
* openejb-ejbd does not have imports to cglib classes
* without csglib a single test fail because of ClassNotFound in RMock
So as Romain suggested it seems to be a missed "test" scope.
Here is the PR: https://github.com/apache/tomee/pull/82
Bets regards,
Svetlin
2017-07-03 14:09 GMT+03:00 Jean-Louis Monteiro <jl...@tomitribe.com>:
> If not needed I'm totally ok.
> Can you submit a PR?
> I'dbe happy to merge it for you
>
>
> Le 3 juil. 2017 11:45, "Svetlin Zarev" <sv...@gmail.com> a
> écrit :
>
> > Hi everyone!
> >
> > Recently CGLIB was added as a dependency to TomEE (commit id: 703e9770),
> > and in turn it brought Apache Ant as "compile" dependency. Yet it's not
> > used by cglib at runtime, so it shouldn't really be packaged in the final
> > assembly.
> >
> > What do you think about excluding it from the packaged TomEE
> distributions
> > ?
> >
> > Kind regards,
> > Svetlin
> >
>
Re: Removing ANT from the packaged tomee distributions
Posted by Jean-Louis Monteiro <jl...@tomitribe.com>.
If not needed I'm totally ok.
Can you submit a PR?
I'dbe happy to merge it for you
Le 3 juil. 2017 11:45, "Svetlin Zarev" <sv...@gmail.com> a
écrit :
> Hi everyone!
>
> Recently CGLIB was added as a dependency to TomEE (commit id: 703e9770),
> and in turn it brought Apache Ant as "compile" dependency. Yet it's not
> used by cglib at runtime, so it shouldn't really be packaged in the final
> assembly.
>
> What do you think about excluding it from the packaged TomEE distributions
> ?
>
> Kind regards,
> Svetlin
>