You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/05/22 18:44:08 UTC

Review Request 59461: Added 'executor_reregister_timeout' agent flag to the tests.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59461/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.


Repository: mesos


Description
-------

This patch updates the tests to make use of the new
'executor_reregister_timeout' agent flag.


Diffs
-----

  src/tests/containerizer/port_mapping_tests.cpp a528382e8b4831b9c7e8dcc877a5e242909f0cd5 
  src/tests/disk_quota_tests.cpp f758bee07c448afe09dc380e99c4a81e2dd9f650 
  src/tests/master_tests.cpp 97d828365489fc10a0260622f7e96627528a324d 
  src/tests/persistent_volume_tests.cpp ef0085316d76bd05a86b7930446f6439b2101645 
  src/tests/slave_recovery_tests.cpp 52e78b6b6280a159233b402ce2849448204d4f11 
  src/tests/slave_tests.cpp 8f81f77aa29d16616d5a38197729baab0fb0cab5 


Diff: https://reviews.apache.org/r/59461/diff/1/


Testing
-------

`make check`


Thanks,

Greg Mann


Re: Review Request 59461: Added 'executor_reregister_timeout' agent flag to the tests.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59461/#review175712
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On May 22, 2017, 6:46 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59461/
> -----------------------------------------------------------
> 
> (Updated May 22, 2017, 6:46 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-7540
>     https://issues.apache.org/jira/browse/MESOS-7540
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the tests to make use of the new
> 'executor_reregister_timeout' agent flag.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/port_mapping_tests.cpp a528382e8b4831b9c7e8dcc877a5e242909f0cd5 
>   src/tests/disk_quota_tests.cpp f758bee07c448afe09dc380e99c4a81e2dd9f650 
>   src/tests/master_tests.cpp 97d828365489fc10a0260622f7e96627528a324d 
>   src/tests/persistent_volume_tests.cpp ef0085316d76bd05a86b7930446f6439b2101645 
>   src/tests/slave_recovery_tests.cpp 52e78b6b6280a159233b402ce2849448204d4f11 
>   src/tests/slave_tests.cpp 8f81f77aa29d16616d5a38197729baab0fb0cab5 
> 
> 
> Diff: https://reviews.apache.org/r/59461/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Re: Review Request 59461: Added 'executor_reregister_timeout' agent flag to the tests.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59461/
-----------------------------------------------------------

(Updated May 22, 2017, 10:39 p.m.)


Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.


Bugs: MESOS-7540
    https://issues.apache.org/jira/browse/MESOS-7540


Repository: mesos


Description
-------

This patch updates the tests to make use of the new
'executor_reregister_timeout' agent flag.


Diffs (updated)
-----

  src/tests/containerizer/port_mapping_tests.cpp a528382e8b4831b9c7e8dcc877a5e242909f0cd5 
  src/tests/disk_quota_tests.cpp f758bee07c448afe09dc380e99c4a81e2dd9f650 
  src/tests/master_tests.cpp 97d828365489fc10a0260622f7e96627528a324d 
  src/tests/persistent_volume_tests.cpp ef0085316d76bd05a86b7930446f6439b2101645 
  src/tests/slave_recovery_tests.cpp 52e78b6b6280a159233b402ce2849448204d4f11 
  src/tests/slave_tests.cpp 8f81f77aa29d16616d5a38197729baab0fb0cab5 


Diff: https://reviews.apache.org/r/59461/diff/2/

Changes: https://reviews.apache.org/r/59461/diff/1-2/


Testing
-------

`make check`


Thanks,

Greg Mann


Re: Review Request 59461: Added 'executor_reregister_timeout' agent flag to the tests.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59461/
-----------------------------------------------------------

(Updated May 22, 2017, 6:46 p.m.)


Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.


Bugs: MESOS-7540
    https://issues.apache.org/jira/browse/MESOS-7540


Repository: mesos


Description
-------

This patch updates the tests to make use of the new
'executor_reregister_timeout' agent flag.


Diffs
-----

  src/tests/containerizer/port_mapping_tests.cpp a528382e8b4831b9c7e8dcc877a5e242909f0cd5 
  src/tests/disk_quota_tests.cpp f758bee07c448afe09dc380e99c4a81e2dd9f650 
  src/tests/master_tests.cpp 97d828365489fc10a0260622f7e96627528a324d 
  src/tests/persistent_volume_tests.cpp ef0085316d76bd05a86b7930446f6439b2101645 
  src/tests/slave_recovery_tests.cpp 52e78b6b6280a159233b402ce2849448204d4f11 
  src/tests/slave_tests.cpp 8f81f77aa29d16616d5a38197729baab0fb0cab5 


Diff: https://reviews.apache.org/r/59461/diff/1/


Testing
-------

`make check`


Thanks,

Greg Mann