You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by GitBox <gi...@apache.org> on 2020/08/31 07:36:03 UTC
[GitHub] [wicket] svenmeier commented on a change in pull request #449: WICKET-6824 Replace slow `String.format` with concatenation
svenmeier commented on a change in pull request #449:
URL: https://github.com/apache/wicket/pull/449#discussion_r479950373
##########
File path: wicket-core/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java
##########
@@ -61,16 +61,16 @@
public static final ResourceReference INDICATOR = new PackageResourceReference(
AbstractDefaultAjaxBehavior.class, "indicator.gif");
- private static final String DYNAMIC_PARAMETER_FUNCTION_TEMPLATE = "function(attrs){%s}";
- private static final String PRECONDITION_FUNCTION_TEMPLATE = "function(attrs){%s}";
- private static final String COMPLETE_HANDLER_FUNCTION_TEMPLATE = "function(attrs, jqXHR, textStatus){%s}";
- private static final String FAILURE_HANDLER_FUNCTION_TEMPLATE = "function(attrs, jqXHR, errorMessage, textStatus){%s}";
- private static final String SUCCESS_HANDLER_FUNCTION_TEMPLATE = "function(attrs, jqXHR, data, textStatus){%s}";
- private static final String AFTER_HANDLER_FUNCTION_TEMPLATE = "function(attrs){%s}";
- private static final String BEFORE_SEND_HANDLER_FUNCTION_TEMPLATE = "function(attrs, jqXHR, settings){%s}";
- private static final String BEFORE_HANDLER_FUNCTION_TEMPLATE = "function(attrs){%s}";
- private static final String INIT_HANDLER_FUNCTION_TEMPLATE = "function(attrs){%s}";
- private static final String DONE_HANDLER_FUNCTION_TEMPLATE = "function(attrs){%s}";
+ private static final String DYNAMIC_PARAMETER_FUNCTION_TEMPLATE = "function(attrs)";
Review comment:
IMHO these constants serve as a good documentation for the functions' actual parameters.
And it will be hard to come up with good names of all used parameter combinations anyway :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org