[jira] [Commented] (SOLR-8648) Support selective clearing up of stored async collection API responses

["Shai Erera (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135670#comment-15135670 ] 

Shai Erera commented on SOLR-8648:
----------------------------------

bq. {{if(req.getParams().getBool("cleanup")) \{}}

* Can you add a space after the 'if'?
* Separately, would be nice if {{DistributedMap#remove()}} would return a boolean/Object, you can avoid the {{.contains}} followed by {{.remove}} check (which also means two accesses to ZK).

bq. {{.setCleanup(true).process(cloudClient);}}

If you're already doing the builder style (which I like), mind as well write that as:

{code}
  .setCleanup(true)
  .process(cloudClient);
{code}

Some general comments:

* Can you also add a test which attempts to delete a non-existing requestId, as well one which attempts to delete the same twice?

* How would the REST call look like? {{/solr/admin/collections?action=REQUESTSTATUS&requestId=foo&cleanup=true}}? I thought that we want to add a {{DELETESTATUS}} specific action, in which case you won't need to add a cleanup parameter?

* What about {{&requestId=-1&cleanup=false}}? I mean, we obviously don't need to support all options, but was just wondering what would the code do? If we added a {{DELETESTATUS}} action, then we could deprecate {{requestId=-1}} at all and remove in 6.0, in exchange for only the latter action. Also, V2-API would be able to handle that with a {{DELETE /solr/admin/...}} vs {{GET /solr/admin/...}}.

What do you think?

> Support selective clearing up of stored async collection API responses
> ----------------------------------------------------------------------
>
>                 Key: SOLR-8648
>                 URL: https://issues.apache.org/jira/browse/SOLR-8648
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Anshum Gupta
>            Assignee: Anshum Gupta
>         Attachments: SOLR-8648.patch
>
>
> The only way to clear up stored collection API responses right now is by sending in '-1' as the request id in the REQUESTSTATUS call. It makes a lot of sense to support selective deletion of stored responses so the ids could be reused.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org