You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/12/08 06:10:41 UTC

[GitHub] [incubator-mxnet] yajiedesign commented on a change in pull request #16997: Fix pip setup.py for windows.

yajiedesign commented on a change in pull request #16997: Fix pip setup.py for windows.
URL: https://github.com/apache/incubator-mxnet/pull/16997#discussion_r355162686
 
 

 ##########
 File path: tools/pip/setup.py
 ##########
 @@ -28,6 +28,9 @@
 if platform.system() == 'Linux':
     sys.argv.append('--universal')
     sys.argv.append('--plat-name=manylinux1_x86_64')
+if platform.system() == 'Windows':
+    sys.argv.append('--universal')
 
 Review comment:
   @leezu because we don't compile C extensions through python.We compile is self and call via ctypes use it.for python this is a pure python package.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services