[GitHub] [maven] michael-o commented on a change in pull request #657: [MNG-7349] Superfluous relocation warning messages

[GitBox <gi...@apache.org>]

michael-o commented on a change in pull request #657:
URL: https://github.com/apache/maven/pull/657#discussion_r783864534



##########
File path: maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java
##########
@@ -181,6 +181,23 @@ public DependencyResolutionResult resolve( DependencyResolutionRequest request )
 
         depRequest.setRoot( node );
 
+        if ( logger.isWarnEnabled() )
+        {
+            for ( DependencyNode child : node.getChildren() )
+            {
+                if ( !child.getRelocations().isEmpty() )
+                {
+                    org.eclipse.aether.artifact.Artifact relocated = child.getDependency().getArtifact();
+                    String message = relocated instanceof org.apache.maven.repository.internal.RelocatedArtifact
+                            ? ( ( org.apache.maven.repository.internal.RelocatedArtifact ) relocated ).getMessage()
+                            : null;
+                    logger.warn( "The artifact " + child.getRelocations().get( 0 ) + " has been relocated to "
+                        + child.getDependency().getArtifact()

Review comment:
       `child.getDependency().getArtifact()` is already available as `relocated`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org