You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficserver.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2014/09/11 21:29:36 UTC

[jira] [Commented] (TS-3051) bad if for perror on AIO.cc

    [ https://issues.apache.org/jira/browse/TS-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14130566#comment-14130566 ] 

ASF subversion and git services commented on TS-3051:
-----------------------------------------------------

Commit 7229900ac4dd78981cb0a7f63faf8ca03980195d in trafficserver's branch refs/heads/master from [~jpeach@apache.org]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=7229900 ]

TS-3051: fix libaio error handling

The libaio API functions return -errno on error, so the error
handling needs to check the resturn code, not look at errno. Replace
calls to perror(3) with Debug(), so debug logging works correctly.


> bad if for perror on AIO.cc
> ---------------------------
>
>                 Key: TS-3051
>                 URL: https://issues.apache.org/jira/browse/TS-3051
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Core
>            Reporter: Juan Pablo Daniel Borgna
>            Assignee: James Peach
>             Fix For: 5.2.0
>
>
> File iocore/aio/AIO.cc on line 569 the condition check of the ret value of io_getevents uses perror and logs when it returns success (until the traffic.log fills the disk and boom)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)