[GitHub] [pulsar] merlimat commented on a change in pull request #7222: Fix bug related to managedLedger properties

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #7222:
URL: https://github.com/apache/pulsar/pull/7222#discussion_r437650906



##########
File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##########
@@ -3245,14 +3243,19 @@ public void setPropertiesFailed(ManagedLedgerException exception, Object ctx) {
     }
 
     @Override
-    public void asyncSetProperties(Map<String, String> properties, final SetPropertiesCallback callback, Object ctx) {
+    public void asyncSetProperties(Map<String, String> properties, boolean isOverwrite,
+                                   final SetPropertiesCallback callback,
+                                   Object ctx) {
+        propertiesMutex.lock();

Review comment:
       The properties feature in ManagedLedger is very broken as described in https://github.com/apache/pulsar/pull/7054#issuecomment-637843729. 
   
   This PR is not addressing the overall issue, so I think it's better to hold off until a proper solution is in place.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org