You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2026/10/04 01:17:03 UTC

[PR] fix(skill-evals): align code-review footer fixtures with the contributing-guide link [magpie]

potiuk opened a new pull request, #1503:
URL: https://github.com/apache/magpie/pull/1503

   ## Summary
   
   - #1407 replaced the Airflow-specific `contributing-docs/05_pull_requests.rst` link in the `pr-management-code-review` AI-attribution footer with `[Contributing guide](<upstream_contributing_docs_url>)`, but the step-7b attribution eval was left behind: its grader prompt still said the footer ends with the Airflow pull-requests doc, and the two "footer present" fixtures still used the old link text.
   - The grader prompt now describes the link by its config key (`upstream_contributing_docs_url`, dropped when unset), and the fixtures use the current `[Contributing guide](...)` link text (still an Airflow URL, as the example project).
   
   Found while running the code-review skill on a stale checkout, where the footer linked a file that doesn't exist in Magpie.
   
   ## Type of change
   
   - [x] Skill change (`.claude/skills/<name>/`) — eval fixtures updated below
   
   ## Test plan
   
   - [x] `prek` hooks pass on the commit
   - [x] For skill changes: eval suite passes for the affected skill — `step-7b-review-body-attribution` 4/4 (Claude-graded)
   
   ## Linked issues
   
   Follow-up to #1407.
   
   ---
   
   Generative AI disclosure: drafted with Claude Code; reviewed by the author.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(skill-evals): align code-review footer fixtures with the contributing-guide link [magpie]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #1503:
URL: https://github.com/apache/magpie/pull/1503


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org