[GitHub] [cassandra] jonmeredith commented on a change in pull request #1501: CASSANDRA-17424 Performance and Semantic Concerns w/ Metrics for Local vs. Remote Requests in StorageProxy

[GitBox <gi...@apache.org>]

jonmeredith commented on a change in pull request #1501:
URL: https://github.com/apache/cassandra/pull/1501#discussion_r831380891



##########
File path: src/java/org/apache/cassandra/service/StorageProxy.java
##########
@@ -1684,6 +1670,9 @@ protected Verb verb()
             // we build this ONLY to perform the sufficiency check that happens on construction
             ReplicaPlans.forWrite(keyspace, cm.consistency(), tk, ReplicaPlans.writeAll);
 
+            // This host isn't a replica, so mark the request as being remote.
+            writeMetrics.remoteRequests.mark();
+

Review comment:
       Is it worth being explicit in this comment that the other path will ultimately update the `localRequests` 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org