You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@apache.org> on 2020/09/18 16:56:57 UTC

Review Request 72885: Made the hierarchical allocator store `FrameworkInfo` internally.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72885/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-10177
    https://issues.apache.org/jira/browse/MESOS-10177


Repository: mesos


Description
-------

To make it possible to add into the allocator debugguing HTTP endpoints
that will need to authorize principal's viewing access to frameworks,
it becomes necessary to store `FrameworkInfo` in the allocator, so that
it can compose an authorization object for the VIEW_FRAMEWORK action.


Diffs
-----

  src/master/allocator/mesos/hierarchical.hpp 7e1980ef74bb4138b83707de7698f1993cc21e41 
  src/master/allocator/mesos/hierarchical.cpp 47f8a2bfa267d68d39d2c255c7c97c8f213d5f69 


Diff: https://reviews.apache.org/r/72885/diff/1/


Testing
-------


Thanks,

Andrei Sekretenko


Re: Review Request 72885: Made the hierarchical allocator store `FrameworkInfo` internally.

Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72885/#review221893
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On Sept. 18, 2020, 4:56 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72885/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2020, 4:56 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-10177
>     https://issues.apache.org/jira/browse/MESOS-10177
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To make it possible to add into the allocator debugguing HTTP endpoints
> that will need to authorize principal's viewing access to frameworks,
> it becomes necessary to store `FrameworkInfo` in the allocator, so that
> it can compose an authorization object for the VIEW_FRAMEWORK action.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 7e1980ef74bb4138b83707de7698f1993cc21e41 
>   src/master/allocator/mesos/hierarchical.cpp 47f8a2bfa267d68d39d2c255c7c97c8f213d5f69 
> 
> 
> Diff: https://reviews.apache.org/r/72885/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>