[GitHub] [helix] jiajunwang commented on a change in pull request #1237: Fix empty host list for instance stoppable response

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #1237:
URL: https://github.com/apache/helix/pull/1237#discussion_r475811851



##########
File path: helix-rest/src/main/java/org/apache/helix/rest/server/service/InstanceServiceImpl.java
##########
@@ -213,7 +219,12 @@ public StoppableCheck getInstanceStoppableCheck(String clusterId, String instanc
           instancesForNextCheck.add(instance);
         }
       } catch (InterruptedException | ExecutionException e) {
-        LOG.error("Failed to get StoppableChecks in parallel. Instance: {}", instance, e);
+        LOG.warn("Failed to get StoppableChecks in parallel. Instance: {}. Caused by {}", instance,

Review comment:
       I think the failure reason does not really matter here (although an Exception looks to be a problem to me more than a warning).
   The real matter thing is that whether the result is complete and fully computed. If not certain, then this is an error.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org