You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/02 08:18:38 UTC
[GitHub] [airflow] kundan1301 opened a new issue #10113: TypeError exception, comparing NoneType and int
kundan1301 opened a new issue #10113:
URL: https://github.com/apache/airflow/issues/10113
<!--
Welcome to Apache Airflow! For a smooth issue process, try to answer the following questions.
Don't worry if they're not all applicable; just try to include what you can :-)
If you need to include code snippets or logs, please put them in fenced code
blocks. If they're super-long, please use the details tag like
<details><summary>super-long log</summary> lots of stuff </details>
Please delete these comment blocks before submitting the issue.
-->
<!--
IMPORTANT!!!
PLEASE CHECK "SIMILAR TO X EXISTING ISSUES" OPTION IF VISIBLE
NEXT TO "SUBMIT NEW ISSUE" BUTTON!!!
PLEASE CHECK IF THIS ISSUE HAS BEEN REPORTED PREVIOUSLY USING SEARCH!!!
Please complete the next sections or the issue will be closed.
This questions are the first thing we need to know to understand the context.
-->
**Apache Airflow version**: 1.10.9
**Environment**: composer
- **Cloud provider or hardware configuration**: google cloud
**What happened**:
TypeError: '>' not supported between instances of 'NoneType' and 'int
At line https://github.com/apache/airflow/blob/1.10.9/airflow/contrib/operators/gcp_transfer_operator.py#L643
None is passed as default timeout but at line
https://github.com/apache/airflow/blob/1.10.9/airflow/contrib/hooks/gcp_transfer_hook.py#L338
its comparing against int.
**stacktrace**
Traceback (most recent call last)
File "/usr/local/lib/airflow/airflow/models/taskinstance.py", line 972, in _run_raw_tas
result = task_copy.execute(context=context
File "/usr/local/lib/airflow/airflow/contrib/operators/gcp_transfer_operator.py", line 643, in execut
hook.wait_for_transfer_job(job, timeout=self.timeout
File "/usr/local/lib/airflow/airflow/contrib/hooks/gcp_api_base_hook.py", line 284, in wrapper_decorato
return func(self, *args, **kwargs
File "/usr/local/lib/airflow/airflow/contrib/hooks/gcp_transfer_hook.py", line 338, in wait_for_transfer_jo
while timeout > 0
TypeError: '>' not supported between instances of 'NoneType' and 'int
looking at source code we may face same exception at line
https://github.com/apache/airflow/blob/1.10.9/airflow/contrib/operators/gcp_transfer_operator.py#L781 as well.
<!-- (please include exact error messages if you can) -->
**What you expected to happen**:
Either pass significantly large value as default timeout for example (10**18) or handle None type as special case while checking for status in while loop.
<!-- What do you think went wrong? -->
<!---
As minimally and precisely as possible. Keep in mind we do not have access to your cluster or dags.
If you are using kubernetes, please attempt to recreate the issue using minikube or kind.
## Install minikube/kind
- Minikube https://minikube.sigs.k8s.io/docs/start/
- Kind https://kind.sigs.k8s.io/docs/user/quick-start/
If this is a UI bug, please provide a screenshot of the bug or a link to a youtube video of the bug in action
You can include images using the .md sytle of
To record a screencast, mac users can use QuickTime and then create an unlisted youtube video with the resulting .mov file.
--->
**Anything else we need to know**:
I can fix this and raise a PR. Let me know.
<!--
How often does this problem occur? Once? Every time etc?
Any relevant logs to include? Put them here in side a detail tag:
<details><summary>x.log</summary> lots of stuff </details>
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj closed issue #10113: TypeError exception, comparing NoneType and int
Posted by GitBox <gi...@apache.org>.
mik-laj closed issue #10113:
URL: https://github.com/apache/airflow/issues/10113
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #10113: TypeError exception, comparing NoneType and int
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #10113:
URL: https://github.com/apache/airflow/issues/10113#issuecomment-682641246
@kundan1301 We no longer update operators in Airflow 1.10. I recommend installing backport packages. https://github.com/apache/airflow#backport-packages
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kundan1301 commented on issue #10113: TypeError exception, comparing NoneType and int
Posted by GitBox <gi...@apache.org>.
kundan1301 commented on issue #10113:
URL: https://github.com/apache/airflow/issues/10113#issuecomment-667656667
@mik-laj I don't think same problem will occur in Airflow 2.0. On this line
https://github.com/apache/airflow/blob/1d68cd2929dbc55b73fed2417cb6ecbba162e4f8/airflow/providers/google/cloud/hooks/cloud_storage_transfer_service.py#L464
I can see that if timeout is None it is set to 60s.
Let me know if we still want to fix for branch 1.10.* . Otherwise we can close this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #10113: TypeError exception, comparing NoneType and int
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #10113:
URL: https://github.com/apache/airflow/issues/10113#issuecomment-667647781
Helllo.
Does this problem also occur in Airflow from the master branch? If not, then you can start using Airflow 2.0 operators thanks to [backport packages](https://github.com/apache/airflow#backport-packages).
Best regards,
Kamill
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org