You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficcontrol.apache.org by Jeremy Mitchell <mi...@apache.org> on 2017/04/18 18:37:31 UTC
Duplicate TO API routes
As we move towards a new authorization model on the TO API which includes
roles, capabilities and tenancy, it's important to remove any cruft from
the API to ease this new implementation. I've put some effort into
organizing the TO routes file (
https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/app/lib/TrafficOpsRoutes.pm#L373)
but I'd also like to remove any duplicate routes.
We have a few duplicates mainly in the area of deliveryservice, servers,
and cachegroups. This jira outlines the duplicates and suggests which
routes to remove - https://issues.apache.org/jira/browse/TC-82
If these routes are being used, they would not be removed until 2.1 giving
everyone time to use the standard ones.
Concerns?
Jeremy
Re: Duplicate TO API routes
Posted by "Eric Friedrich (efriedri)" <ef...@cisco.com>.
Thumbs up on removal
> On May 19, 2017, at 1:58 PM, Jeremy Mitchell <mi...@gmail.com> wrote:
>
> @Eric_Friedrich - any concerns from you regarding removal of these
> duplicate routes? Here they are to summarize:
>
> remove GET /api/$version/deliveryservices/list in favor of GET
> /api/$version/deliveryservices
> remove GET /api/$version/deliveryservices/:id/get in favor of GET
> /api/$version/deliveryservices/:id
> remove POST /api/$version/deliveryservices/create in favor of POST
> /api/$version/deliveryservices
> remove PUT /api/$version/deliveryservices/:id/update in favor of PUT
> /api/$version/deliveryservices/:id
> remove GET /api/$version/cachegroups/list in favor of GET
> /api/$version/cachegroups
> remove POST /api/$version/cachegroups/create in favor of POST
> /api/$version/cachegroups
> remove PUT /api/$version/cachegroups/:id/update in favor of PUT
> /api/$version/cachegroups/:id
> remove DELETE /api/$version/cachegroups/:id/delete in favor of DELETE
> /api/$version/cachegroups/:id
> remove POST /api/$version/servers/create in favor of POST
> /api/$version/servers
> remove PUT /api/$version/servers/:id/update in favor of PUT
> /api/$version/servers/:id
>
> On Fri, Apr 28, 2017 at 10:32 AM, Dewayne Richardson <de...@gmail.com>
> wrote:
>
>> And as long as the "duplicate" routes point to the same Perl module, I'm ok
>> as well
>>
>> On Tue, Apr 18, 2017 at 4:27 PM, Dave Neuman <ne...@apache.org> wrote:
>>
>>> I assume you did a check of the client to make sure it wasn't using those
>>> routes?
>>> Other than that, no concerns here.
>>>
>>> On Tue, Apr 18, 2017 at 12:37 PM, Jeremy Mitchell <
>> mitchell852@apache.org>
>>> wrote:
>>>
>>>> As we move towards a new authorization model on the TO API which
>> includes
>>>> roles, capabilities and tenancy, it's important to remove any cruft
>> from
>>>> the API to ease this new implementation. I've put some effort into
>>>> organizing the TO routes file (
>>>> https://github.com/apache/incubator-trafficcontrol/blob/
>>>> master/traffic_ops/app/lib/TrafficOpsRoutes.pm#L373)
>>>> but I'd also like to remove any duplicate routes.
>>>>
>>>> We have a few duplicates mainly in the area of deliveryservice,
>> servers,
>>>> and cachegroups. This jira outlines the duplicates and suggests which
>>>> routes to remove - https://issues.apache.org/jira/browse/TC-82
>>>>
>>>> If these routes are being used, they would not be removed until 2.1
>>> giving
>>>> everyone time to use the standard ones.
>>>>
>>>> Concerns?
>>>>
>>>> Jeremy
>>>>
>>>
>>
Re: Duplicate TO API routes
Posted by Jeremy Mitchell <mi...@gmail.com>.
@Eric_Friedrich - any concerns from you regarding removal of these
duplicate routes? Here they are to summarize:
remove GET /api/$version/deliveryservices/list in favor of GET
/api/$version/deliveryservices
remove GET /api/$version/deliveryservices/:id/get in favor of GET
/api/$version/deliveryservices/:id
remove POST /api/$version/deliveryservices/create in favor of POST
/api/$version/deliveryservices
remove PUT /api/$version/deliveryservices/:id/update in favor of PUT
/api/$version/deliveryservices/:id
remove GET /api/$version/cachegroups/list in favor of GET
/api/$version/cachegroups
remove POST /api/$version/cachegroups/create in favor of POST
/api/$version/cachegroups
remove PUT /api/$version/cachegroups/:id/update in favor of PUT
/api/$version/cachegroups/:id
remove DELETE /api/$version/cachegroups/:id/delete in favor of DELETE
/api/$version/cachegroups/:id
remove POST /api/$version/servers/create in favor of POST
/api/$version/servers
remove PUT /api/$version/servers/:id/update in favor of PUT
/api/$version/servers/:id
On Fri, Apr 28, 2017 at 10:32 AM, Dewayne Richardson <de...@gmail.com>
wrote:
> And as long as the "duplicate" routes point to the same Perl module, I'm ok
> as well
>
> On Tue, Apr 18, 2017 at 4:27 PM, Dave Neuman <ne...@apache.org> wrote:
>
> > I assume you did a check of the client to make sure it wasn't using those
> > routes?
> > Other than that, no concerns here.
> >
> > On Tue, Apr 18, 2017 at 12:37 PM, Jeremy Mitchell <
> mitchell852@apache.org>
> > wrote:
> >
> > > As we move towards a new authorization model on the TO API which
> includes
> > > roles, capabilities and tenancy, it's important to remove any cruft
> from
> > > the API to ease this new implementation. I've put some effort into
> > > organizing the TO routes file (
> > > https://github.com/apache/incubator-trafficcontrol/blob/
> > > master/traffic_ops/app/lib/TrafficOpsRoutes.pm#L373)
> > > but I'd also like to remove any duplicate routes.
> > >
> > > We have a few duplicates mainly in the area of deliveryservice,
> servers,
> > > and cachegroups. This jira outlines the duplicates and suggests which
> > > routes to remove - https://issues.apache.org/jira/browse/TC-82
> > >
> > > If these routes are being used, they would not be removed until 2.1
> > giving
> > > everyone time to use the standard ones.
> > >
> > > Concerns?
> > >
> > > Jeremy
> > >
> >
>
Re: Duplicate TO API routes
Posted by Dewayne Richardson <de...@gmail.com>.
And as long as the "duplicate" routes point to the same Perl module, I'm ok
as well
On Tue, Apr 18, 2017 at 4:27 PM, Dave Neuman <ne...@apache.org> wrote:
> I assume you did a check of the client to make sure it wasn't using those
> routes?
> Other than that, no concerns here.
>
> On Tue, Apr 18, 2017 at 12:37 PM, Jeremy Mitchell <mi...@apache.org>
> wrote:
>
> > As we move towards a new authorization model on the TO API which includes
> > roles, capabilities and tenancy, it's important to remove any cruft from
> > the API to ease this new implementation. I've put some effort into
> > organizing the TO routes file (
> > https://github.com/apache/incubator-trafficcontrol/blob/
> > master/traffic_ops/app/lib/TrafficOpsRoutes.pm#L373)
> > but I'd also like to remove any duplicate routes.
> >
> > We have a few duplicates mainly in the area of deliveryservice, servers,
> > and cachegroups. This jira outlines the duplicates and suggests which
> > routes to remove - https://issues.apache.org/jira/browse/TC-82
> >
> > If these routes are being used, they would not be removed until 2.1
> giving
> > everyone time to use the standard ones.
> >
> > Concerns?
> >
> > Jeremy
> >
>
Re: Duplicate TO API routes
Posted by Jeremy Mitchell <mi...@gmail.com>.
yep, not used by TO client, dave.
On Tue, Apr 18, 2017 at 4:27 PM, Dave Neuman <ne...@apache.org> wrote:
> I assume you did a check of the client to make sure it wasn't using those
> routes?
> Other than that, no concerns here.
>
> On Tue, Apr 18, 2017 at 12:37 PM, Jeremy Mitchell <mi...@apache.org>
> wrote:
>
> > As we move towards a new authorization model on the TO API which includes
> > roles, capabilities and tenancy, it's important to remove any cruft from
> > the API to ease this new implementation. I've put some effort into
> > organizing the TO routes file (
> > https://github.com/apache/incubator-trafficcontrol/blob/
> > master/traffic_ops/app/lib/TrafficOpsRoutes.pm#L373)
> > but I'd also like to remove any duplicate routes.
> >
> > We have a few duplicates mainly in the area of deliveryservice, servers,
> > and cachegroups. This jira outlines the duplicates and suggests which
> > routes to remove - https://issues.apache.org/jira/browse/TC-82
> >
> > If these routes are being used, they would not be removed until 2.1
> giving
> > everyone time to use the standard ones.
> >
> > Concerns?
> >
> > Jeremy
> >
>
Re: Duplicate TO API routes
Posted by Dave Neuman <ne...@apache.org>.
I assume you did a check of the client to make sure it wasn't using those
routes?
Other than that, no concerns here.
On Tue, Apr 18, 2017 at 12:37 PM, Jeremy Mitchell <mi...@apache.org>
wrote:
> As we move towards a new authorization model on the TO API which includes
> roles, capabilities and tenancy, it's important to remove any cruft from
> the API to ease this new implementation. I've put some effort into
> organizing the TO routes file (
> https://github.com/apache/incubator-trafficcontrol/blob/
> master/traffic_ops/app/lib/TrafficOpsRoutes.pm#L373)
> but I'd also like to remove any duplicate routes.
>
> We have a few duplicates mainly in the area of deliveryservice, servers,
> and cachegroups. This jira outlines the duplicates and suggests which
> routes to remove - https://issues.apache.org/jira/browse/TC-82
>
> If these routes are being used, they would not be removed until 2.1 giving
> everyone time to use the standard ones.
>
> Concerns?
>
> Jeremy
>