You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Attila Magyar <am...@hortonworks.com> on 2017/01/27 18:24:53 UTC
Review Request 56022: Content of yarn-env.sh on host is not same as
in the downloaded config file from Ambari UI
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56022/
-----------------------------------------------------------
Review request for Ambari, Laszlo Puskas, Robert Levas, and Sebastian Toader.
Bugs: AMBARI-19683
https://issues.apache.org/jira/browse/AMBARI-19683
Repository: ambari
Description
-------
Exported YARN configuration was different than the stored configuration. I replaced the Python logic that assembled yarn security opt with jinja template logic.
Diffs
-----
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py aed8abc
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-env.xml 190684c
Diff: https://reviews.apache.org/r/56022/diff/
Testing
-------
Tested manually:
- created a cluster with YARN
- enabled kerberos
- exported configuration
- checked that yarn security opts are presented in the exported config
- disablde kerberos
- checked that yarn security opts are not presented in the exported config
Unittests are running...
Thanks,
Attila Magyar
Re: Review Request 56022: Content of yarn-env.sh on host is not same
as in the downloaded config file from Ambari UI
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56022/#review163410
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-env.xml (line 156)
<https://reviews.apache.org/r/56022/#comment234870>
Lets confirm that we do not need HDP stack upgrade changes.
- Sumit Mohanty
On Jan. 27, 2017, 7:11 p.m., Attila Magyar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56022/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2017, 7:11 p.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Robert Levas, and Sebastian Toader.
>
>
> Bugs: AMBARI-19683
> https://issues.apache.org/jira/browse/AMBARI-19683
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Exported YARN configuration was different than the stored configuration. I replaced the Python logic that assembled yarn security opt with jinja template logic.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py c56e72f
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-env.xml 190684c
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 92e2e29
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 774f3c6
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 0eb5561
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py da93096
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py d4341e1
>
> Diff: https://reviews.apache.org/r/56022/diff/
>
>
> Testing
> -------
>
> Tested manually:
> - created a cluster with YARN
> - enabled kerberos
> - exported configuration
> - checked that yarn security opts are presented in the exported config
> - disablde kerberos
> - checked that yarn security opts are not presented in the exported config
>
> existing unittests ran successfully
> one irrelevant failure:
>
> java.lang.AssertionError
> org.apache.ambari.server.serveraction.kerberos.UpdateKerberosConfigsServerActionTest.testUpdateConfigForceSecurityEnabled(UpdateKerberosC
>
>
> Thanks,
>
> Attila Magyar
>
>
Re: Review Request 56022: Content of yarn-env.sh on host is not same
as in the downloaded config file from Ambari UI
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56022/#review163656
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On Jan. 31, 2017, 2:43 p.m., Attila Magyar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56022/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 2:43 p.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Robert Levas, and Sebastian Toader.
>
>
> Bugs: AMBARI-19683
> https://issues.apache.org/jira/browse/AMBARI-19683
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Exported YARN configuration was different than the stored configuration. I replaced the Python logic that assembled yarn security opt with jinja template logic.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py aed8abc
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-env.xml d8531b1
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py 4d47925
> ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-env.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/metainfo.xml ad457b2
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 62a4d46
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 774f3c6
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 0eb5561
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py 5ebfb45
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py d4341e1
>
> Diff: https://reviews.apache.org/r/56022/diff/
>
>
> Testing
> -------
>
> Tested manually:
> - created a cluster with YARN
> - enabled kerberos
> - exported configuration
> - checked that yarn security opts are presented in the exported config
> - disablde kerberos
> - checked that yarn security opts are not presented in the exported config
>
> existing unittests ran successfully
> one irrelevant failure:
>
> java.lang.AssertionError
> org.apache.ambari.server.serveraction.kerberos.UpdateKerberosConfigsServerActionTest.testUpdateConfigForceSecurityEnabled(UpdateKerberosC
>
>
> Thanks,
>
> Attila Magyar
>
>
Re: Review Request 56022: Content of yarn-env.sh on host is not same
as in the downloaded config file from Ambari UI
Posted by Attila Magyar <am...@hortonworks.com>.
> On Jan. 31, 2017, 6:53 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-env.xml, line 21
> > <https://reviews.apache.org/r/56022/diff/3/?file=1620010#file1620010line21>
> >
> > Does this file differ from the one used for HDP 3.0? If so, they need to be identical for now, until we figure out what will change in HDP 3.0.
The yarn-env sh content is the same. The content of the whole file is not because the yarn-env in HDP2.6 is inherited from other templates. I checked the inherited properties and they all have a counterpart in HDP3.0 yarn-env.
- Attila
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56022/#review163694
-----------------------------------------------------------
On Jan. 31, 2017, 1:43 p.m., Attila Magyar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56022/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 1:43 p.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Robert Levas, and Sebastian Toader.
>
>
> Bugs: AMBARI-19683
> https://issues.apache.org/jira/browse/AMBARI-19683
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Exported YARN configuration was different than the stored configuration. I replaced the Python logic that assembled yarn security opt with jinja template logic.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py aed8abc
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-env.xml d8531b1
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py 4d47925
> ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-env.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/metainfo.xml ad457b2
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 62a4d46
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 774f3c6
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 0eb5561
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py 5ebfb45
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py d4341e1
>
> Diff: https://reviews.apache.org/r/56022/diff/
>
>
> Testing
> -------
>
> Tested manually:
> - created a cluster with YARN
> - enabled kerberos
> - exported configuration
> - checked that yarn security opts are presented in the exported config
> - disablde kerberos
> - checked that yarn security opts are not presented in the exported config
>
> existing unittests ran successfully
> one irrelevant failure:
>
> java.lang.AssertionError
> org.apache.ambari.server.serveraction.kerberos.UpdateKerberosConfigsServerActionTest.testUpdateConfigForceSecurityEnabled(UpdateKerberosC
>
>
> Thanks,
>
> Attila Magyar
>
>
Re: Review Request 56022: Content of yarn-env.sh on host is not same
as in the downloaded config file from Ambari UI
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56022/#review163694
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-env.xml (line 21)
<https://reviews.apache.org/r/56022/#comment235169>
Does this file differ from the one used for HDP 3.0? If so, they need to be identical for now, until we figure out what will change in HDP 3.0.
- Alejandro Fernandez
On Jan. 31, 2017, 1:43 p.m., Attila Magyar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56022/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 1:43 p.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Robert Levas, and Sebastian Toader.
>
>
> Bugs: AMBARI-19683
> https://issues.apache.org/jira/browse/AMBARI-19683
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Exported YARN configuration was different than the stored configuration. I replaced the Python logic that assembled yarn security opt with jinja template logic.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py aed8abc
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-env.xml d8531b1
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py 4d47925
> ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-env.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/metainfo.xml ad457b2
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 62a4d46
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 774f3c6
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 0eb5561
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py 5ebfb45
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py d4341e1
>
> Diff: https://reviews.apache.org/r/56022/diff/
>
>
> Testing
> -------
>
> Tested manually:
> - created a cluster with YARN
> - enabled kerberos
> - exported configuration
> - checked that yarn security opts are presented in the exported config
> - disablde kerberos
> - checked that yarn security opts are not presented in the exported config
>
> existing unittests ran successfully
> one irrelevant failure:
>
> java.lang.AssertionError
> org.apache.ambari.server.serveraction.kerberos.UpdateKerberosConfigsServerActionTest.testUpdateConfigForceSecurityEnabled(UpdateKerberosC
>
>
> Thanks,
>
> Attila Magyar
>
>
Re: Review Request 56022: Content of yarn-env.sh on host is not same
as in the downloaded config file from Ambari UI
Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56022/
-----------------------------------------------------------
(Updated Jan. 31, 2017, 1:43 p.m.)
Review request for Ambari, Laszlo Puskas, Robert Levas, and Sebastian Toader.
Changes
-------
- Moved template logic from HDP2.3/YARN to HDP2.6/YARN
- Modified HDP3.0/YARN same way as 2.6
Bugs: AMBARI-19683
https://issues.apache.org/jira/browse/AMBARI-19683
Repository: ambari
Description
-------
Exported YARN configuration was different than the stored configuration. I replaced the Python logic that assembled yarn security opt with jinja template logic.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py aed8abc
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-env.xml d8531b1
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py 4d47925
ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-env.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/metainfo.xml ad457b2
ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 62a4d46
ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 774f3c6
ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 0eb5561
ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py 5ebfb45
ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py d4341e1
Diff: https://reviews.apache.org/r/56022/diff/
Testing
-------
Tested manually:
- created a cluster with YARN
- enabled kerberos
- exported configuration
- checked that yarn security opts are presented in the exported config
- disablde kerberos
- checked that yarn security opts are not presented in the exported config
existing unittests ran successfully
one irrelevant failure:
java.lang.AssertionError
org.apache.ambari.server.serveraction.kerberos.UpdateKerberosConfigsServerActionTest.testUpdateConfigForceSecurityEnabled(UpdateKerberosC
Thanks,
Attila Magyar
Re: Review Request 56022: Content of yarn-env.sh on host is not same
as in the downloaded config file from Ambari UI
Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56022/
-----------------------------------------------------------
(Updated Jan. 27, 2017, 7:11 p.m.)
Review request for Ambari, Laszlo Puskas, Robert Levas, and Sebastian Toader.
Changes
-------
fixed tests
Bugs: AMBARI-19683
https://issues.apache.org/jira/browse/AMBARI-19683
Repository: ambari
Description
-------
Exported YARN configuration was different than the stored configuration. I replaced the Python logic that assembled yarn security opt with jinja template logic.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py c56e72f
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-env.xml 190684c
ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 92e2e29
ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 774f3c6
ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 0eb5561
ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py da93096
ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py d4341e1
Diff: https://reviews.apache.org/r/56022/diff/
Testing (updated)
-------
Tested manually:
- created a cluster with YARN
- enabled kerberos
- exported configuration
- checked that yarn security opts are presented in the exported config
- disablde kerberos
- checked that yarn security opts are not presented in the exported config
existing unittests ran successfully
one irrelevant failure:
java.lang.AssertionError
org.apache.ambari.server.serveraction.kerberos.UpdateKerberosConfigsServerActionTest.testUpdateConfigForceSecurityEnabled(UpdateKerberosC
Thanks,
Attila Magyar
Re: Review Request 56022: Content of yarn-env.sh on host is not same
as in the downloaded config file from Ambari UI
Posted by Sebastian Toader <st...@hortonworks.com>.
> On Jan. 27, 2017, 8 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-env.xml, line 157
> > <https://reviews.apache.org/r/56022/diff/1/?file=1617907#file1617907line157>
> >
> > In that case, this should belong in yarn-env for HDP 2.6.
> > Earlier versions will not have the rm_security_ops variable in params.py
Does config export clever enough currently to pick up yarn-env template from HDP 2.6 in case the cluster is using HDP 2.6?
- Sebastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56022/#review163309
-----------------------------------------------------------
On Jan. 27, 2017, 7:24 p.m., Attila Magyar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56022/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2017, 7:24 p.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Robert Levas, and Sebastian Toader.
>
>
> Bugs: AMBARI-19683
> https://issues.apache.org/jira/browse/AMBARI-19683
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Exported YARN configuration was different than the stored configuration. I replaced the Python logic that assembled yarn security opt with jinja template logic.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py aed8abc
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-env.xml 190684c
>
> Diff: https://reviews.apache.org/r/56022/diff/
>
>
> Testing
> -------
>
> Tested manually:
> - created a cluster with YARN
> - enabled kerberos
> - exported configuration
> - checked that yarn security opts are presented in the exported config
> - disablde kerberos
> - checked that yarn security opts are not presented in the exported config
>
> Unittests are running...
>
>
> Thanks,
>
> Attila Magyar
>
>
Re: Review Request 56022: Content of yarn-env.sh on host is not same
as in the downloaded config file from Ambari UI
Posted by Attila Magyar <am...@hortonworks.com>.
> On Jan. 27, 2017, 7 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-env.xml, line 157
> > <https://reviews.apache.org/r/56022/diff/1/?file=1617907#file1617907line157>
> >
> > In that case, this should belong in yarn-env for HDP 2.6.
> > Earlier versions will not have the rm_security_ops variable in params.py
>
> Sebastian Toader wrote:
> Does config export clever enough currently to pick up yarn-env template from HDP 2.6 in case the cluster is using HDP 2.6?
It is wrapped into a conditional that checks whether rm_security_opts is defined (and it is only defined when stack is 2.6). HDP 2.6 doesn't have yarn-env.xml. I should have duplicated the whole file from 2.3
- Attila
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56022/#review163309
-----------------------------------------------------------
On Jan. 27, 2017, 7:11 p.m., Attila Magyar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56022/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2017, 7:11 p.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Robert Levas, and Sebastian Toader.
>
>
> Bugs: AMBARI-19683
> https://issues.apache.org/jira/browse/AMBARI-19683
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Exported YARN configuration was different than the stored configuration. I replaced the Python logic that assembled yarn security opt with jinja template logic.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py c56e72f
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-env.xml 190684c
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 92e2e29
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 774f3c6
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 0eb5561
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py da93096
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py d4341e1
>
> Diff: https://reviews.apache.org/r/56022/diff/
>
>
> Testing
> -------
>
> Tested manually:
> - created a cluster with YARN
> - enabled kerberos
> - exported configuration
> - checked that yarn security opts are presented in the exported config
> - disablde kerberos
> - checked that yarn security opts are not presented in the exported config
>
> existing unittests ran successfully
> one irrelevant failure:
>
> java.lang.AssertionError
> org.apache.ambari.server.serveraction.kerberos.UpdateKerberosConfigsServerActionTest.testUpdateConfigForceSecurityEnabled(UpdateKerberosC
>
>
> Thanks,
>
> Attila Magyar
>
>
Re: Review Request 56022: Content of yarn-env.sh on host is not same
as in the downloaded config file from Ambari UI
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56022/#review163309
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-env.xml (line 157)
<https://reviews.apache.org/r/56022/#comment234731>
In that case, this should belong in yarn-env for HDP 2.6.
Earlier versions will not have the rm_security_ops variable in params.py
- Alejandro Fernandez
On Jan. 27, 2017, 6:24 p.m., Attila Magyar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56022/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2017, 6:24 p.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Robert Levas, and Sebastian Toader.
>
>
> Bugs: AMBARI-19683
> https://issues.apache.org/jira/browse/AMBARI-19683
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Exported YARN configuration was different than the stored configuration. I replaced the Python logic that assembled yarn security opt with jinja template logic.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py aed8abc
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-env.xml 190684c
>
> Diff: https://reviews.apache.org/r/56022/diff/
>
>
> Testing
> -------
>
> Tested manually:
> - created a cluster with YARN
> - enabled kerberos
> - exported configuration
> - checked that yarn security opts are presented in the exported config
> - disablde kerberos
> - checked that yarn security opts are not presented in the exported config
>
> Unittests are running...
>
>
> Thanks,
>
> Attila Magyar
>
>
Re: Review Request 56022: Content of yarn-env.sh on host is not same
as in the downloaded config file from Ambari UI
Posted by Attila Magyar <am...@hortonworks.com>.
> On Jan. 27, 2017, 6:31 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-env.xml, line 157
> > <https://reviews.apache.org/r/56022/diff/1/?file=1617907#file1617907line157>
> >
> > Do existing clusters with HDP 2.3 or higher also need this change or only fresh installs?
Only HDP 2.6, but I don't know whether existing clusters should have it or only new installs. Does anyone has information about this?
- Attila
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56022/#review163303
-----------------------------------------------------------
On Jan. 27, 2017, 6:24 p.m., Attila Magyar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56022/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2017, 6:24 p.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Robert Levas, and Sebastian Toader.
>
>
> Bugs: AMBARI-19683
> https://issues.apache.org/jira/browse/AMBARI-19683
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Exported YARN configuration was different than the stored configuration. I replaced the Python logic that assembled yarn security opt with jinja template logic.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py aed8abc
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-env.xml 190684c
>
> Diff: https://reviews.apache.org/r/56022/diff/
>
>
> Testing
> -------
>
> Tested manually:
> - created a cluster with YARN
> - enabled kerberos
> - exported configuration
> - checked that yarn security opts are presented in the exported config
> - disablde kerberos
> - checked that yarn security opts are not presented in the exported config
>
> Unittests are running...
>
>
> Thanks,
>
> Attila Magyar
>
>
Re: Review Request 56022: Content of yarn-env.sh on host is not same
as in the downloaded config file from Ambari UI
Posted by Sebastian Toader <st...@hortonworks.com>.
> On Jan. 27, 2017, 7:31 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-env.xml, line 157
> > <https://reviews.apache.org/r/56022/diff/1/?file=1617907#file1617907line157>
> >
> > Do existing clusters with HDP 2.3 or higher also need this change or only fresh installs?
>
> Attila Magyar wrote:
> Only HDP 2.6, but I don't know whether existing clusters should have it or only new installs. Does anyone has information about this?
Only HDP 2.6 and above with Ambari 2.5 and above.
- Sebastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56022/#review163303
-----------------------------------------------------------
On Jan. 27, 2017, 7:24 p.m., Attila Magyar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56022/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2017, 7:24 p.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Robert Levas, and Sebastian Toader.
>
>
> Bugs: AMBARI-19683
> https://issues.apache.org/jira/browse/AMBARI-19683
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Exported YARN configuration was different than the stored configuration. I replaced the Python logic that assembled yarn security opt with jinja template logic.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py aed8abc
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-env.xml 190684c
>
> Diff: https://reviews.apache.org/r/56022/diff/
>
>
> Testing
> -------
>
> Tested manually:
> - created a cluster with YARN
> - enabled kerberos
> - exported configuration
> - checked that yarn security opts are presented in the exported config
> - disablde kerberos
> - checked that yarn security opts are not presented in the exported config
>
> Unittests are running...
>
>
> Thanks,
>
> Attila Magyar
>
>
Re: Review Request 56022: Content of yarn-env.sh on host is not same
as in the downloaded config file from Ambari UI
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56022/#review163303
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-env.xml (line 157)
<https://reviews.apache.org/r/56022/#comment234727>
Do existing clusters with HDP 2.3 or higher also need this change or only fresh installs?
- Alejandro Fernandez
On Jan. 27, 2017, 6:24 p.m., Attila Magyar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56022/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2017, 6:24 p.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Robert Levas, and Sebastian Toader.
>
>
> Bugs: AMBARI-19683
> https://issues.apache.org/jira/browse/AMBARI-19683
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Exported YARN configuration was different than the stored configuration. I replaced the Python logic that assembled yarn security opt with jinja template logic.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py aed8abc
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-env.xml 190684c
>
> Diff: https://reviews.apache.org/r/56022/diff/
>
>
> Testing
> -------
>
> Tested manually:
> - created a cluster with YARN
> - enabled kerberos
> - exported configuration
> - checked that yarn security opts are presented in the exported config
> - disablde kerberos
> - checked that yarn security opts are not presented in the exported config
>
> Unittests are running...
>
>
> Thanks,
>
> Attila Magyar
>
>