You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2025/02/05 17:36:17 UTC
[PR] GH-45433: [Python] Remove Cython workarounds [arrow]
pitrou opened a new pull request, #45437:
URL: https://github.com/apache/arrow/pull/45437
### Rationale for this change
We've accumulated multiple workarounds for various Cython issues over the years.
Now that we require at least Cython 3.0, we can remove some of those.
### Are these changes tested?
Yes, by existing CI builds and tests.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45433: [Python] Remove Cython workarounds [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #45437:
URL: https://github.com/apache/arrow/pull/45437#issuecomment-2637592582
@github-actions crossbow submit -g python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45433: [Python] Remove Cython workarounds [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #45437:
URL: https://github.com/apache/arrow/pull/45437#issuecomment-2639934295
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit e28fcd656f1c5b1696f259e76a7f2a22a437e4f2.
There were 8 benchmark results with an error:
- Commit Run on `amd64-m5-4xlarge-linux` at [2025-02-06 13:34:39Z](https://conbench.ursa.dev/compare/runs/83b978f60cb542c78f2ba12c85de5c6c...e2d84a0847014a8485af779d83f352dc/)
- [`tpch` (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-03, scale_factor=1](https://conbench.ursa.dev/benchmark-results/067a49be7d5172b380001a1645b9348d)
- [`tpch` (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-03, scale_factor=10](https://conbench.ursa.dev/benchmark-results/067a49d1bafa7d9280008ffb74c70519)
- and 6 more (see the report linked below)
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/36790248823) has more details. It also includes information about 27 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45433: [Python] Remove Cython workarounds [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #45437:
URL: https://github.com/apache/arrow/pull/45437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45433: [Python] Remove Cython workarounds [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #45437:
URL: https://github.com/apache/arrow/pull/45437#issuecomment-2637692383
CI failures look unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45433: [Python] Remove Cython workarounds [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45437:
URL: https://github.com/apache/arrow/pull/45437#issuecomment-2637598208
Revision: c6fb259c08c71e1ba042899b6ee46202c7a33a35
Submitted crossbow builds: [ursacomputing/crossbow @ actions-a84656ce93](https://github.com/ursacomputing/crossbow/branches/all?query=actions-a84656ce93)
|Task|Status|
|----|------|
|example-python-minimal-build-fedora-conda|[](https://github.com/ursacomputing/crossbow/actions/runs/13163264883/job/36737085259)|
|example-python-minimal-build-ubuntu-venv|[](https://github.com/ursacomputing/crossbow/actions/runs/13163264955/job/36737085719)|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/13163265177/job/36737086407)|
|test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/13163265419/job/36737087304)|
|test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/13163264824/job/36737084831)|
|test-conda-python-3.10-pandas-latest-numpy-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/13163264765/job/36737084539)|
|test-conda-python-3.10-substrait|[](https://github.com/ursacomputing/crossbow/actions/runs/13163265202/job/36737086287)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/13163264410/job/36737082758)|
|test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/13163264766/job/36737084642)|
|test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/13163265210/job/36737086295)|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/13163265050/job/36737086000)|
|test-conda-python-3.11-pandas-latest-numpy-1.26|[](https://github.com/ursacomputing/crossbow/actions/runs/13163264938/job/36737085396)|
|test-conda-python-3.11-pandas-latest-numpy-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/13163265557/job/36737087796)|
|test-conda-python-3.11-pandas-nightly-numpy-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/13163265389/job/36737087074)|
|test-conda-python-3.11-pandas-upstream_devel-numpy-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/13163264705/job/36737083784)|
|test-conda-python-3.11-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/13163264774/job/36737084382)|
|test-conda-python-3.12|[](https://github.com/ursacomputing/crossbow/actions/runs/13163265017/job/36737085884)|
|test-conda-python-3.12-cpython-debug|[](https://github.com/ursacomputing/crossbow/actions/runs/13163264646/job/36737083417)|
|test-conda-python-3.13|[](https://github.com/ursacomputing/crossbow/actions/runs/13163264317/job/36737082854)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/13163264872/job/36737085324)|
|test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5|[](https://github.com/ursacomputing/crossbow/actions/runs/13163264622/job/36737083357)|
|test-conda-python-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/13163265277/job/36737086947)|
|test-cuda-python-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/13163264731/job/36737084075)|
|test-debian-12-python-3-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/13163264657/job/36737083476)|
|test-debian-12-python-3-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/13163264508/job/36737082974)|
|test-fedora-39-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/13163264746/job/36737084161)|
|test-ubuntu-22.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/13163265218/job/36737086584)|
|test-ubuntu-22.04-python-313-freethreading|[](https://github.com/ursacomputing/crossbow/actions/runs/13163265481/job/36737087455)|
|test-ubuntu-24.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/13163265060/job/36737086106)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org