You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "db-scnakandala (via GitHub)" <gi...@apache.org> on 2023/09/11 17:29:14 UTC
[GitHub] [spark] db-scnakandala opened a new pull request, #42873: [SPARK-45117][SQL] Implement missing otherCopyArgs for the MultiCommutativeOp expression
db-scnakandala opened a new pull request, #42873:
URL: https://github.com/apache/spark/pull/42873
### What changes were proposed in this pull request?
- This PR implements the missing otherCopyArgs in the MultiCommutativeOp expression
### Why are the changes needed?
- Without this method implementation, calling toJSON will throw an exception from the TreeNode::jsonFields method.
- This is because the jsonFields method has an assertion that the number of fields defined in the constructor is equal to the number of field values (productIterator.toSeq ++ otherCopyArgs).
- The originalRoot field of the MultiCommutativeOp is not part of the productIterator. Hence, it has to be explicitly set in the otherCopyArgs field.
### Does this PR introduce _any_ user-facing change?
- No
### How was this patch tested?
- Added unit test
### Was this patch authored or co-authored using generative AI tooling?
- No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #42873: [SPARK-45117][SQL] Implement missing otherCopyArgs for the MultiCommutativeOp expression
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #42873:
URL: https://github.com/apache/spark/pull/42873#issuecomment-1715991930
thanks, merging to master/3.5!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #42873: [SPARK-45117][SQL] Implement missing otherCopyArgs for the MultiCommutativeOp expression
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #42873:
URL: https://github.com/apache/spark/pull/42873#issuecomment-1714817793
can you do a rebase or push an empty commit to re-trigger the test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] db-scnakandala commented on pull request #42873: [SPARK-45117][SQL] Implement missing otherCopyArgs for the MultiCommutativeOp expression
Posted by "db-scnakandala (via GitHub)" <gi...@apache.org>.
db-scnakandala commented on PR #42873:
URL: https://github.com/apache/spark/pull/42873#issuecomment-1715066918
> can you do a rebase or push an empty commit to re-trigger the test?
@cloud-fan The PR has now passed the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #42873: [SPARK-45117][SQL] Implement missing otherCopyArgs for the MultiCommutativeOp expression
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #42873: [SPARK-45117][SQL] Implement missing otherCopyArgs for the MultiCommutativeOp expression
URL: https://github.com/apache/spark/pull/42873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org