You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sanjay Tripathi <sa...@citrix.com> on 2013/05/21 10:13:27 UTC
Review Request: CLOUDSTACK-2286: Volume created from snapshot state is in
allocated state instead of Ready state which is letting Primary storage not
to increment the resources
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11298/
-----------------------------------------------------------
Review request for cloudstack, Devdeep Singh and Nitin Mehta.
Description
-------
CLOUDSTACK-2286: Volume created from snapshot state is in allocated state instead of Ready state which is letting Primary storage not to increment the resources
This addresses bug CLOUDSTACK-2286.
Diffs
-----
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java 7fdf6bb
Diff: https://reviews.apache.org/r/11298/diff/
Testing
-------
Verified on my local CloudStack setup.
Thanks,
Sanjay Tripathi
Re: Review Request: CLOUDSTACK-2286: Volume created from snapshot state is
in allocated state instead of Ready state which is letting Primary storage
not to increment the resources
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11298/#review21568
-----------------------------------------------------------
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
<https://reviews.apache.org/r/11298/#comment44616>
Why not get an updated volumeObject before calling processEvent (from the volFactory like you are doing in the callback)? That way the change is not required in the callback.
- Devdeep Singh
On May 21, 2013, 8:13 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11298/
> -----------------------------------------------------------
>
> (Updated May 21, 2013, 8:13 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Nitin Mehta.
>
>
> Description
> -------
>
> CLOUDSTACK-2286: Volume created from snapshot state is in allocated state instead of Ready state which is letting Primary storage not to increment the resources
>
>
> This addresses bug CLOUDSTACK-2286.
>
>
> Diffs
> -----
>
> engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java 7fdf6bb
>
> Diff: https://reviews.apache.org/r/11298/diff/
>
>
> Testing
> -------
>
> Verified on my local CloudStack setup.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request: CLOUDSTACK-2286: Volume created from snapshot state is
in allocated state instead of Ready state which is letting Primary storage
not to increment the resources
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11298/#review21575
-----------------------------------------------------------
Ship it!
Ship It!
- Devdeep Singh
On June 7, 2013, 11:41 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11298/
> -----------------------------------------------------------
>
> (Updated June 7, 2013, 11:41 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Nitin Mehta.
>
>
> Description
> -------
>
> CLOUDSTACK-2286: Volume created from snapshot state is in allocated state instead of Ready state which is letting Primary storage not to increment the resources
>
>
> This addresses bug CLOUDSTACK-2286.
>
>
> Diffs
> -----
>
> engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java 7fdf6bb
>
> Diff: https://reviews.apache.org/r/11298/diff/
>
>
> Testing
> -------
>
> Verified on my local CloudStack setup.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request: CLOUDSTACK-2286: Volume created from snapshot state is
in allocated state instead of Ready state which is letting Primary storage
not to increment the resources
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11298/#review21574
-----------------------------------------------------------
Commit da5c4619c394eaedec55c277bc5e71de379d6600 in branch refs/heads/master from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=da5c461 ]
CLOUDSTACK-2286: Volume created from snapshot state is in allocated state instead of Ready state which is letting Primary storage not to increment the resources.
- ASF Subversion and Git Services
On June 7, 2013, 11:41 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11298/
> -----------------------------------------------------------
>
> (Updated June 7, 2013, 11:41 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Nitin Mehta.
>
>
> Description
> -------
>
> CLOUDSTACK-2286: Volume created from snapshot state is in allocated state instead of Ready state which is letting Primary storage not to increment the resources
>
>
> This addresses bug CLOUDSTACK-2286.
>
>
> Diffs
> -----
>
> engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java 7fdf6bb
>
> Diff: https://reviews.apache.org/r/11298/diff/
>
>
> Testing
> -------
>
> Verified on my local CloudStack setup.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request: CLOUDSTACK-2286: Volume created from snapshot state is
in allocated state instead of Ready state which is letting Primary storage
not to increment the resources
Posted by Sanjay Tripathi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11298/
-----------------------------------------------------------
(Updated June 7, 2013, 11:41 a.m.)
Review request for cloudstack, Devdeep Singh and Nitin Mehta.
Changes
-------
Updated patch after incorporating the review comments.
Description
-------
CLOUDSTACK-2286: Volume created from snapshot state is in allocated state instead of Ready state which is letting Primary storage not to increment the resources
This addresses bug CLOUDSTACK-2286.
Diffs (updated)
-----
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java 7fdf6bb
Diff: https://reviews.apache.org/r/11298/diff/
Testing
-------
Verified on my local CloudStack setup.
Thanks,
Sanjay Tripathi