You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Isabelle Giguere (Jira)" <ji...@apache.org> on 2021/01/29 17:21:00 UTC
[jira] [Commented] (SOLR-13209) NullPointerException from call in
org.apache.solr.search.SolrIndexSearcher.getDocSet
[ https://issues.apache.org/jira/browse/SOLR-13209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274593#comment-17274593 ]
Isabelle Giguere commented on SOLR-13209:
-----------------------------------------
Throwing an exception for a null query makes sense for the request in the description. This request is invalid, missing a value for group.query.
But the exception should not be thrown from such a low-level method, because it could impact faceting too, where the user doesn't have control over the queries that are produced by the faceting process. Refer to SOLR-8319.
Group queries parameters should be validated, and an exception thrown right away.
> NullPointerException from call in org.apache.solr.search.SolrIndexSearcher.getDocSet
> ------------------------------------------------------------------------------------
>
> Key: SOLR-13209
> URL: https://issues.apache.org/jira/browse/SOLR-13209
> Project: Solr
> Issue Type: Bug
> Affects Versions: master (9.0)
> Environment: h1. Steps to reproduce
> * Use a Linux machine.
> * Build commit {{ea2c8ba}} of Solr as described in the section below.
> * Build the films collection as described below.
> * Start the server using the command {{./bin/solr start -f -p 8983 -s /tmp/home}}
> * Request the URL given in the bug description.
> h1. Compiling the server
> {noformat}
> git clone https://github.com/apache/lucene-solr
> cd lucene-solr
> git checkout ea2c8ba
> ant compile
> cd solr
> ant server
> {noformat}
> h1. Building the collection and reproducing the bug
> We followed [Exercise 2|http://lucene.apache.org/solr/guide/7_5/solr-tutorial.html#exercise-2] from the [Solr Tutorial|http://lucene.apache.org/solr/guide/7_5/solr-tutorial.html].
> {noformat}
> mkdir -p /tmp/home
> echo '<?xml version="1.0" encoding="UTF-8" ?><solr></solr>' > /tmp/home/solr.xml
> {noformat}
> In one terminal start a Solr instance in foreground:
> {noformat}
> ./bin/solr start -f -p 8983 -s /tmp/home
> {noformat}
> In another terminal, create a collection of movies, with no shards and no replication, and initialize it:
> {noformat}
> bin/solr create -c films
> curl -X POST -H 'Content-type:application/json' --data-binary '{"add-field": {"name":"name", "type":"text_general", "multiValued":false, "stored":true}}' http://localhost:8983/solr/films/schema
> curl -X POST -H 'Content-type:application/json' --data-binary '{"add-copy-field" : {"source":"*","dest":"_text_"}}' http://localhost:8983/solr/films/schema
> ./bin/post -c films example/films/films.json
> curl -v “URL_BUG”
> {noformat}
> Please check the issue description below to find the “URL_BUG” that will allow you to reproduce the issue reported.
> Reporter: Cesar Rodriguez
> Priority: Minor
> Labels: diffblue, newdev
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Requesting the following URL causes Solr to return an HTTP 500 error response:
> {noformat}
> http://localhost:8983/solr/films/select?group=true&group.query
> {noformat}
> The error response seems to be caused by the following uncaught exception:
> {noformat}
> java.lang.NullPointerException
> at java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:936)
> at org.apache.solr.util.ConcurrentLRUCache.get(ConcurrentLRUCache.java:124)
> at org.apache.solr.search.FastLRUCache.get(FastLRUCache.java:163)
> at org.apache.solr.search.SolrIndexSearcher.getDocSet(SolrIndexSearcher.java:792)
> at org.apache.solr.search.Grouping$CommandQuery.createFirstPassCollector(Grouping.java:860)
> at org.apache.solr.search.Grouping.execute(Grouping.java:327)
> at org.apache.solr.handler.component.QueryComponent.doProcessGroupedSearch(QueryComponent.java:1408)
> at org.apache.solr.handler.component.QueryComponent.process(QueryComponent.java:365)
> at org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:298)
> at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:199)
> at org.apache.solr.core.SolrCore.execute(SolrCore.java:2559)
> [...]
> {noformat}
> Method {{org.apache.solr.search.SolrIndexSearcher.getDocSet()}}, at line 792 calls {{filterCache.get(absQ)}} where {{absQ}} is a null pointer. I think this null pointer comes in fact from the caller, but I don't fully follow the logic of the code.
> To set up an environment to reproduce this bug, follow the description in the ‘Environment’ field.
> We automatically found this issue and ~70 more like this using [Diffblue Microservices Testing|https://www.diffblue.com/labs/?utm_source=solr-br]. Find more information on this [fuzz testing campaign|https://www.diffblue.com/blog/2018/12/19/diffblue-microservice-testing-a-sneak-peek-at-our-early-product-and-results?utm_source=solr-br].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org