You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/25 06:30:31 UTC
[GitHub] [flink] HuangXingBo opened a new pull request #14746: [FLINK-21020][build] Bump Jackson to 2.12.1
HuangXingBo opened a new pull request #14746:
URL: https://github.com/apache/flink/pull/14746
## What is the purpose of the change
*This pull request will bump all jackson dependencies to 2.12.1 in release-1.11*
## Verifying this change
This change added tests and can be verified as follows:
- *Original Tests*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14746: [FLINK-21020][build] Bump Jackson to 2.12.1
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14746:
URL: https://github.com/apache/flink/pull/14746#issuecomment-766580728
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14746: [FLINK-21020][build] Bump Jackson to 2.12.1
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14746:
URL: https://github.com/apache/flink/pull/14746#issuecomment-766580728
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 253747531da6be3b0b511f7d67a770ea3140fa70 (Mon Jan 25 06:33:33 UTC 2021)
**Warnings:**
* **3 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14746: [FLINK-21020][build] Bump Jackson to 2.10.5.1
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14746:
URL: https://github.com/apache/flink/pull/14746#issuecomment-766587422
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "253747531da6be3b0b511f7d67a770ea3140fa70",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12441",
"triggerID" : "253747531da6be3b0b511f7d67a770ea3140fa70",
"triggerType" : "PUSH"
}, {
"hash" : "6d38e4ebf6ed9265a3b4981af0e9876d20791a38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12465",
"triggerID" : "6d38e4ebf6ed9265a3b4981af0e9876d20791a38",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 253747531da6be3b0b511f7d67a770ea3140fa70 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12441)
* 6d38e4ebf6ed9265a3b4981af0e9876d20791a38 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12465)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] HuangXingBo commented on a change in pull request #14746: [FLINK-21020][build] Bump Jackson to 2.10.5.1
Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on a change in pull request #14746:
URL: https://github.com/apache/flink/pull/14746#discussion_r564993564
##########
File path: flink-connectors/flink-connector-elasticsearch5/src/main/resources/META-INF/NOTICE
##########
@@ -7,10 +7,12 @@ The Apache Software Foundation (http://www.apache.org/).
This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
- com.carrotsearch:hppc:0.7.1
-- com.fasterxml.jackson.core:jackson-core:2.10.1
-- com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:2.10.1
-- com.fasterxml.jackson.dataformat:jackson-dataformat-smile:2.10.1
-- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.10.1
+- com.fasterxml.jackson.core:jackson-core:2.10.5
+- com.fasterxml.jackson.core:jackson-databind:2.10.5.1
+- com.fasterxml.jackson.core:jackson-annotations:2.10.5
Review comment:
Yes, I was surprised at the beginning. Later I found that starting from `2.10.4`, the scope of `jackson-dataformat-yaml`'s dependence on `jackson-databind` has changed from `provided` to `compile`.
In fact, from `2.11.0`, the scope of `jackson-dataformat-cbor` and `jackson-dataformat-smile`s dependence on `jackson-databind` has also changed from `provided` to `compile`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14746: [FLINK-21020][build] Bump Jackson to 2.12.1
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14746:
URL: https://github.com/apache/flink/pull/14746#issuecomment-766587422
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "253747531da6be3b0b511f7d67a770ea3140fa70",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "253747531da6be3b0b511f7d67a770ea3140fa70",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 253747531da6be3b0b511f7d67a770ea3140fa70 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #14746: [FLINK-21020][build] Bump Jackson to 2.10.5.1
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14746:
URL: https://github.com/apache/flink/pull/14746#discussion_r564612264
##########
File path: flink-connectors/flink-connector-elasticsearch5/src/main/resources/META-INF/NOTICE
##########
@@ -7,10 +7,12 @@ The Apache Software Foundation (http://www.apache.org/).
This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
- com.carrotsearch:hppc:0.7.1
-- com.fasterxml.jackson.core:jackson-core:2.10.1
-- com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:2.10.1
-- com.fasterxml.jackson.dataformat:jackson-dataformat-smile:2.10.1
-- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.10.1
+- com.fasterxml.jackson.core:jackson-core:2.10.5
+- com.fasterxml.jackson.core:jackson-databind:2.10.5.1
+- com.fasterxml.jackson.core:jackson-annotations:2.10.5
Review comment:
well this is interesting; in 2.10.1 the dataformats had a `provided` dependency on databind/annotations, but since 2.10.4 they are compile dependencies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14746: [FLINK-21020][build] Bump Jackson to 2.12.1
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14746:
URL: https://github.com/apache/flink/pull/14746#issuecomment-766587422
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14746: [FLINK-21020][build] Bump Jackson to 2.10.5.1
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14746:
URL: https://github.com/apache/flink/pull/14746#issuecomment-766587422
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "253747531da6be3b0b511f7d67a770ea3140fa70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12441",
"triggerID" : "253747531da6be3b0b511f7d67a770ea3140fa70",
"triggerType" : "PUSH"
}, {
"hash" : "6d38e4ebf6ed9265a3b4981af0e9876d20791a38",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12465",
"triggerID" : "6d38e4ebf6ed9265a3b4981af0e9876d20791a38",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6d38e4ebf6ed9265a3b4981af0e9876d20791a38 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12465)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14746: [FLINK-21020][build] Bump Jackson to 2.12.1
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14746:
URL: https://github.com/apache/flink/pull/14746#issuecomment-766587422
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "253747531da6be3b0b511f7d67a770ea3140fa70",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12441",
"triggerID" : "253747531da6be3b0b511f7d67a770ea3140fa70",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 253747531da6be3b0b511f7d67a770ea3140fa70 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12441)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14746: [FLINK-21020][build] Bump Jackson to 2.10.5.1
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14746:
URL: https://github.com/apache/flink/pull/14746#issuecomment-766580728
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 6d38e4ebf6ed9265a3b4981af0e9876d20791a38 (Fri May 28 08:07:15 UTC 2021)
**Warnings:**
* **3 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14746: [FLINK-21020][build] Bump Jackson to 2.10.5.1
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14746:
URL: https://github.com/apache/flink/pull/14746#issuecomment-766587422
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "253747531da6be3b0b511f7d67a770ea3140fa70",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12441",
"triggerID" : "253747531da6be3b0b511f7d67a770ea3140fa70",
"triggerType" : "PUSH"
}, {
"hash" : "6d38e4ebf6ed9265a3b4981af0e9876d20791a38",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6d38e4ebf6ed9265a3b4981af0e9876d20791a38",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 253747531da6be3b0b511f7d67a770ea3140fa70 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12441)
* 6d38e4ebf6ed9265a3b4981af0e9876d20791a38 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #14746: [FLINK-21020][build] Bump Jackson to 2.10.5.1
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #14746:
URL: https://github.com/apache/flink/pull/14746
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #14746: [FLINK-21020][build] Bump Jackson to 2.10.5.1
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14746:
URL: https://github.com/apache/flink/pull/14746#discussion_r564521250
##########
File path: flink-connectors/flink-sql-connector-elasticsearch6/src/main/resources/META-INF/NOTICE
##########
@@ -6,10 +6,12 @@ The Apache Software Foundation (http://www.apache.org/).
This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
-- com.fasterxml.jackson.core:jackson-core:2.10.1
-- com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:2.10.1
-- com.fasterxml.jackson.dataformat:jackson-dataformat-smile:2.10.1
-- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.10.1
+- com.fasterxml.jackson.core:jackson-core:2.10.5
+- com.fasterxml.jackson.core:jackson-databind:2.10.5.1
Review comment:
same as above
##########
File path: flink-kubernetes/src/main/resources/META-INF/NOTICE
##########
@@ -6,19 +6,19 @@ The Apache Software Foundation (http://www.apache.org/).
This project bundles the following dependencies under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt)
-- com.fasterxml.jackson.core:jackson-annotations:2.10.1
-- com.fasterxml.jackson.core:jackson-core:2.10.1
-- com.fasterxml.jackson.core:jackson-databind:2.10.1
-- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.10.1
-- com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.10.1
+- com.fasterxml.jackson.core:jackson-annotations:2.10.5
+- com.fasterxml.jackson.core:jackson-core:2.10.5
+- com.fasterxml.jackson.core:jackson-databind:2.10.5.1
+- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.10.5
+- com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.10.5
- com.squareup.okhttp3:logging-interceptor:3.12.6
- com.squareup.okhttp3:okhttp:3.12.1
- com.squareup.okio:okio:1.15.0
- io.fabric8:kubernetes-client:4.9.2
- io.fabric8:kubernetes-model:4.9.2
- io.fabric8:kubernetes-model-common:4.9.2
- io.fabric8:zjsonpatch:0.3.0
-- org.yaml:snakeyaml:1.24
+- org.yaml:snakeyaml:1.27
Review comment:
I assume this is a copy&paste error?
##########
File path: flink-connectors/flink-connector-elasticsearch5/src/main/resources/META-INF/NOTICE
##########
@@ -7,10 +7,12 @@ The Apache Software Foundation (http://www.apache.org/).
This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
- com.carrotsearch:hppc:0.7.1
-- com.fasterxml.jackson.core:jackson-core:2.10.1
-- com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:2.10.1
-- com.fasterxml.jackson.dataformat:jackson-dataformat-smile:2.10.1
-- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.10.1
+- com.fasterxml.jackson.core:jackson-core:2.10.5
+- com.fasterxml.jackson.core:jackson-databind:2.10.5.1
+- com.fasterxml.jackson.core:jackson-annotations:2.10.5
Review comment:
these 2 are incorrect; this module (and likely others with a similar problem) is only binding jackson-core.
##########
File path: flink-connectors/flink-sql-connector-elasticsearch7/src/main/resources/META-INF/NOTICE
##########
@@ -7,10 +7,12 @@ The Apache Software Foundation (http://www.apache.org/).
This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
- com.carrotsearch:hppc:0.8.1
-- com.fasterxml.jackson.core:jackson-core:2.10.1
-- com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:2.10.1
-- com.fasterxml.jackson.dataformat:jackson-dataformat-smile:2.10.1
-- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.10.1
+- com.fasterxml.jackson.core:jackson-core:2.10.5
+- com.fasterxml.jackson.core:jackson-databind:2.10.5.1
+- com.fasterxml.jackson.core:jackson-annotations:2.10.5
Review comment:
same as above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14746: [FLINK-21020][build] Bump Jackson to 2.12.1
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14746:
URL: https://github.com/apache/flink/pull/14746#issuecomment-766587422
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "253747531da6be3b0b511f7d67a770ea3140fa70",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12441",
"triggerID" : "253747531da6be3b0b511f7d67a770ea3140fa70",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 253747531da6be3b0b511f7d67a770ea3140fa70 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12441)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #14746: [FLINK-21020][build] Bump Jackson to 2.10.5.1
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14746:
URL: https://github.com/apache/flink/pull/14746#discussion_r564582995
##########
File path: flink-connectors/flink-connector-elasticsearch5/src/main/resources/META-INF/NOTICE
##########
@@ -7,10 +7,12 @@ The Apache Software Foundation (http://www.apache.org/).
This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
- com.carrotsearch:hppc:0.7.1
-- com.fasterxml.jackson.core:jackson-core:2.10.1
-- com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:2.10.1
-- com.fasterxml.jackson.dataformat:jackson-dataformat-smile:2.10.1
-- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.10.1
+- com.fasterxml.jackson.core:jackson-core:2.10.5
+- com.fasterxml.jackson.core:jackson-databind:2.10.5.1
+- com.fasterxml.jackson.core:jackson-annotations:2.10.5
Review comment:
huh...at least in 1.12 this actually seems to be correct...I'm wondering why that is the case...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org