You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/12/30 14:52:30 UTC
[GitHub] [incubator-doris] zhaojintaozhao opened a new issue #5176: [BUG]The image file saved by calling the dump interface may be broken.
zhaojintaozhao opened a new issue #5176:
URL: https://github.com/apache/incubator-doris/issues/5176
We kown doris provides a dump interface to dump metadata from the memory. After call dump interface, It will save a new image file from current metadata.
However, in some time (for example, when Doris is performing compaction), the image file dumped from the memory may be broken and cannot be used. When we put this image file to FE metadata, FE will restart failed because FE can't load image file normally.
I analyze the dump function, I find that before FE save image it doesn't lock ClusterInfoService and does not call the function: fixBugAfterMetadataReplayed of Catalog.java.
When compaction tasks are running, FE may save image file successfuly but that file may be broken and cannot be read.
So Before dumping the image file, FE shoul lock the ClusterInfoService and after all compaction tasks are complete. After that, the image file generated from the memory can be used properly.
I have fix this bug.
I want to integrate my optimize into the community .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on issue #5176: [BUG]The image file saved by calling the dump interface may be broken.
Posted by GitBox <gi...@apache.org>.
yangzhg commented on issue #5176:
URL: https://github.com/apache/incubator-doris/issues/5176#issuecomment-757646988
it is appreciated if you could submit a pull request to fix this problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org