You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/02/05 04:41:29 UTC

[kudu-CR] [tablet] fix compilation warning in rowset info.cc

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18202


Change subject: [tablet] fix compilation warning in rowset_info.cc
......................................................................

[tablet] fix compilation warning in rowset_info.cc

src/kudu/tablet/rowset_info.cc:207:21: warning: loop variable 'col_id' of type 'const kudu::ColumnId' creates a copy from type 'const kudu::ColumnId' [-Wrange-loop-analysis]
    for (const auto col_id : col_ids) {
                    ^
src/kudu/tablet/rowset_info.cc:207:10: note: use reference type 'const kudu::ColumnId &' to prevent copying
    for (const auto col_id : col_ids) {
         ^~~~~~~~~~~~~~~~~~~
                    &

Change-Id: I25379f9764d7c6c6699740a06877301b624c1f54
---
M src/kudu/tablet/rowset_info.cc
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/18202/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I25379f9764d7c6c6699740a06877301b624c1f54
Gerrit-Change-Number: 18202
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [tablet] fix compilation warning in rowset info.cc

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18202 )

Change subject: [tablet] fix compilation warning in rowset_info.cc
......................................................................

[tablet] fix compilation warning in rowset_info.cc

src/kudu/tablet/rowset_info.cc:207:21: warning: loop variable 'col_id' of type 'const kudu::ColumnId' creates a copy from type 'const kudu::ColumnId' [-Wrange-loop-analysis]
    for (const auto col_id : col_ids) {
                    ^
src/kudu/tablet/rowset_info.cc:207:10: note: use reference type 'const kudu::ColumnId &' to prevent copying
    for (const auto col_id : col_ids) {
         ^~~~~~~~~~~~~~~~~~~
                    &

Change-Id: I25379f9764d7c6c6699740a06877301b624c1f54
Reviewed-on: http://gerrit.cloudera.org:8080/18202
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/tablet/rowset_info.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Andrew Wong: Looks good to me, approved
  Alexey Serbin: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I25379f9764d7c6c6699740a06877301b624c1f54
Gerrit-Change-Number: 18202
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [tablet] fix compilation warning in rowset info.cc

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [tablet] fix compilation warning in rowset_info.cc
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/18202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I25379f9764d7c6c6699740a06877301b624c1f54
Gerrit-Change-Number: 18202
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [tablet] fix compilation warning in rowset info.cc

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18202 )

Change subject: [tablet] fix compilation warning in rowset_info.cc
......................................................................


Patch Set 1: Code-Review+2

Thanks for this bit of cleanup!


-- 
To view, visit http://gerrit.cloudera.org:8080/18202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25379f9764d7c6c6699740a06877301b624c1f54
Gerrit-Change-Number: 18202
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 05 Feb 2022 04:46:19 +0000
Gerrit-HasComments: No

[kudu-CR] [tablet] fix compilation warning in rowset info.cc

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18202 )

Change subject: [tablet] fix compilation warning in rowset_info.cc
......................................................................


Patch Set 1: Verified+1

unrelated test failures:
  * org.apache.kudu.client.TestAsyncKuduSession
  * MultiThreadedTabletTest/3.DeleteAndReinsert


-- 
To view, visit http://gerrit.cloudera.org:8080/18202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25379f9764d7c6c6699740a06877301b624c1f54
Gerrit-Change-Number: 18202
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 05 Feb 2022 05:35:48 +0000
Gerrit-HasComments: No