You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/04/28 17:01:19 UTC

[GitHub] [accumulo] vallari118 opened a new pull request #2043: Changed KeyTest for assertArrayEquals assertion

vallari118 opened a new pull request #2043:
URL: https://github.com/apache/accumulo/pull/2043


   Changed KeyTest.java file with assertTrue to assertArrayEquals


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] Manno15 commented on pull request #2043: Changed KeyTest for assertArrayEquals assertion

Posted by GitBox <gi...@apache.org>.
Manno15 commented on pull request #2043:
URL: https://github.com/apache/accumulo/pull/2043#issuecomment-829107196


   Accumulo 2.1.0-SNAPSHOT requires Java 11.  In the image above, you are building with java 8. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] vallari118 commented on pull request #2043: Changed KeyTest for assertArrayEquals assertion

Posted by GitBox <gi...@apache.org>.
vallari118 commented on pull request #2043:
URL: https://github.com/apache/accumulo/pull/2043#issuecomment-828978271


   https://github.com/apache/accumulo/compare/main...vallari118:dev-assertTrueArray-Fix?expand=1 Check This


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] vallari118 commented on pull request #2043: Changed KeyTest for assertArrayEquals assertion

Posted by GitBox <gi...@apache.org>.
vallari118 commented on pull request #2043:
URL: https://github.com/apache/accumulo/pull/2043#issuecomment-829134851


   I am using Java 11 to compile.
   
   ![image](https://user-images.githubusercontent.com/46676995/116540601-fe39d400-a907-11eb-9824-b17b1c5f771f.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] EdColeman commented on pull request #2043: Changed KeyTest for assertArrayEquals assertion

Posted by GitBox <gi...@apache.org>.
EdColeman commented on pull request #2043:
URL: https://github.com/apache/accumulo/pull/2043#issuecomment-829120598


   Your changes are now visible - not sure what was going on there.
   As @Manno15 shared, you need jdk-11 to build the 2.1.x line of Accumulo
   
   If you can build / run the QA tests, your code should pass - one of the things is that the build will enforce the ordering of the imports so they are standard across the project (static imports first, then alphabetical)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] vallari118 commented on pull request #2043: Changed KeyTest for assertArrayEquals assertion

Posted by GitBox <gi...@apache.org>.
vallari118 commented on pull request #2043:
URL: https://github.com/apache/accumulo/pull/2043#issuecomment-828977812


   I have pushed the changes to the same branch of my Repo with which I created PR. In the PR I am able to see all 3 commits done by me. Can you please check ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] EdColeman edited a comment on pull request #2043: Changed KeyTest for assertArrayEquals assertion

Posted by GitBox <gi...@apache.org>.
EdColeman edited a comment on pull request #2043:
URL: https://github.com/apache/accumulo/pull/2043#issuecomment-829138992


   When you ran maven, the error shows you are running jdk-8 from the command line.  Do you have JAVA_HOME set on the command line? For example, my env:
   `
   $ env | grep JAVA
   JAVA_HOME=/usr/java/jdk-11
   
   and
   
   $ java --version
   openjdk 11 2018-09-25
   OpenJDK Runtime Environment 18.9 (build 11+28)
   OpenJDK 64-Bit Server VM 18.9 (build 11+28, mixed mode)
   `
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] vallari118 commented on pull request #2043: Changed KeyTest for assertArrayEquals assertion

Posted by GitBox <gi...@apache.org>.
vallari118 commented on pull request #2043:
URL: https://github.com/apache/accumulo/pull/2043#issuecomment-828979209


   Also my project is not getting set locally. 
   ![image](https://user-images.githubusercontent.com/46676995/116511406-041dbe00-a8e4-11eb-9b49-f9f49a647642.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] EdColeman commented on pull request #2043: Changed KeyTest for assertArrayEquals assertion

Posted by GitBox <gi...@apache.org>.
EdColeman commented on pull request #2043:
URL: https://github.com/apache/accumulo/pull/2043#issuecomment-829138992


   When you ran maven, the error shows you are running jdk-8 from the command line.  Do you have JAVA_HOME set on the command line? For example, my env:
   `
   > env | grep JAVA
   JAVA_HOME=/usr/java/jdk-11
   
   and
   
   > java --version
   openjdk 11 2018-09-25
   OpenJDK Runtime Environment 18.9 (build 11+28)
   OpenJDK 64-Bit Server VM 18.9 (build 11+28, mixed mode)
   `
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] EdColeman commented on pull request #2043: Changed KeyTest for assertArrayEquals assertion

Posted by GitBox <gi...@apache.org>.
EdColeman commented on pull request #2043:
URL: https://github.com/apache/accumulo/pull/2043#issuecomment-832276346


   Superseded by https://github.com/apache/accumulo/pull/2079


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] EdColeman closed pull request #2043: Changed KeyTest for assertArrayEquals assertion

Posted by GitBox <gi...@apache.org>.
EdColeman closed pull request #2043:
URL: https://github.com/apache/accumulo/pull/2043


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] EdColeman commented on pull request #2043: Changed KeyTest for assertArrayEquals assertion

Posted by GitBox <gi...@apache.org>.
EdColeman commented on pull request #2043:
URL: https://github.com/apache/accumulo/pull/2043#issuecomment-828742812


   You indicated that you fixed the issue - but they are not showing up in github / this PR.  You need to push your changes to your repo with the same branch that you created the PR - that should trigger github to update the PR with the latest files.  As it is now, your commit goes to a page with the following note: `This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository`
   And the code there does not look like it has been corrected.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org