You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/11/19 18:46:20 UTC

[GitHub] eiri commented on a change in pull request #1747: Set query server env variable in Makefile for isolated eunit tests

eiri commented on a change in pull request #1747: Set query server env variable in Makefile for isolated eunit tests
URL: https://github.com/apache/couchdb/pull/1747#discussion_r234736882
 
 

 ##########
 File path: Makefile
 ##########
 @@ -148,6 +148,7 @@ check: all
 # target: eunit - Run EUnit tests, use EUNIT_OPTS to provide custom options
 eunit: export BUILDDIR = $(shell pwd)
 eunit: export ERL_AFLAGS = -config $(shell pwd)/rel/files/eunit.config
+eunit: export COUCHDB_QUERY_SERVER_JAVASCRIPT = $(shell pwd)/bin/couchjs $(shell pwd)/share/server/main.js
 
 Review comment:
   @iilyak I guess we can, but it's inconsistent with usage `pwd` everywhere else and feels kind of flimsy, setting env var in one step then depending on it in another.
   
   Why do you want this change? It's not like here is a performance penalty we care about.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services