You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/12/02 01:23:10 UTC

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7775: Include commons-lang3

Jackie-Jiang commented on a change in pull request #7775:
URL: https://github.com/apache/pinot/pull/7775#discussion_r760693989



##########
File path: pinot-clients/pom.xml
##########
@@ -48,6 +48,10 @@
       <artifactId>pinot-spi</artifactId>
       <scope>provided</scope>
     </dependency>
+    <dependency>
+      <groupId>org.apache.commons</groupId>
+      <artifactId>commons-lang3</artifactId>
+    </dependency>

Review comment:
       `commons-lang3` is already included in the `pinot-spi`. I think the issue is that `pinot-spi` is added as `provided`. @xiangfu0 Any idea why we add `pinot-spi` as `provided` here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org