You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/31 16:16:38 UTC
[GitHub] [airflow] uranusjr opened a new pull request #15117: Remove user_id from API schema
uranusjr opened a new pull request #15117:
URL: https://github.com/apache/airflow/pull/15117
Fix #15059. The role schema doesn't seem to contain an ID at all (only the role name), so I just removed the user ID.
---
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #15117: Remove user_id from API schema
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #15117:
URL: https://github.com/apache/airflow/pull/15117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #15117: Remove user_id from API schema
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #15117:
URL: https://github.com/apache/airflow/pull/15117#issuecomment-814933097
> What are quarantined tests, and how do I read logs for their failures? I can see some of them are failing (in `test_views.py` and `test_local_task_jobs.py`), but can’t find what tests exactly and why.
Quarantined test failures can be ignored, they are mostly flaky tests, docs for it are here: https://github.com/apache/airflow/blob/master/TESTING.rst#quarantined-tests
Some of our tests are quarantined. This means that this test will be run in isolation and that it will be re-run several times. Also when quarantined tests fail, the whole test suite will not fail. The quarantined tests are usually **flaky tests** that need some attention and fix.
Those tests are marked with @pytest.mark.quarantined annotation. Those tests are skipped by default. You can enable them with --include-quarantined flag. You can also decide to only run tests with -m quarantined flag to run only those tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15117: Remove user_id from API schema
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15117:
URL: https://github.com/apache/airflow/pull/15117#issuecomment-811314368
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #15117: Remove user_id from API schema
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #15117:
URL: https://github.com/apache/airflow/pull/15117#issuecomment-814865211
What are quarantined tests, and how do I read logs for their failures? I can see some of them are failing (in `test_views.py` and `test_local_task_jobs.py`), but can’t find what tests exactly and why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #15117: Remove user_id from API schema
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #15117:
URL: https://github.com/apache/airflow/pull/15117#issuecomment-812736051
Can you take a look at the failing tests please @uranusjr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org