You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by marti1125 <gi...@git.apache.org> on 2014/06/30 21:42:54 UTC
[GitHub] cordova-lib pull request: removed "pkgName "
GitHub user marti1125 opened a pull request:
https://github.com/apache/cordova-lib/pull/49
removed "pkgName "
https://issues.apache.org/jira/browse/CB-7055
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/marti1125/cordova-lib CB-7055
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/49.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #49
----
commit d190f776405ad4ea7026695d842b0a390c423460
Author: Willy Aguirre <ma...@gmail.com>
Date: 2014-06-30T19:41:20Z
removed "pkgName "
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: removed "pkgName "
Posted by rodms10 <gi...@git.apache.org>.
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-lib/pull/49#issuecomment-47591641
r+! @zalun, good to merge by me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: removed "pkgName "
Posted by marti1125 <gi...@git.apache.org>.
Github user marti1125 commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/49#discussion_r14377248
--- Diff: cordova-lib/src/cordova/metadata/firefoxos_parser.js ---
@@ -58,8 +58,7 @@ module.exports.prototype = {
manifest.installs_allowed_from = manifest.installs_allowed_from || ['*'];
manifest.version = config.version();
- manifest.name = config.name();
- manifest.pkgName = config.packageName();
+ manifest.name = config.name();
--- End diff --
ok :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: removed "pkgName "
Posted by rodms10 <gi...@git.apache.org>.
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-lib/pull/49#issuecomment-47590172
Tested it, works fine. Just a minor nit on whitespaces. Thanks again!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: removed "pkgName "
Posted by rodms10 <gi...@git.apache.org>.
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/49#discussion_r14377111
--- Diff: cordova-lib/src/cordova/metadata/firefoxos_parser.js ---
@@ -58,8 +58,7 @@ module.exports.prototype = {
manifest.installs_allowed_from = manifest.installs_allowed_from || ['*'];
manifest.version = config.version();
- manifest.name = config.name();
- manifest.pkgName = config.packageName();
+ manifest.name = config.name();
--- End diff --
nit: Can you remove the extra whitespace in the end of this line?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: removed "pkgName "
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/49
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---