You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/10/21 06:03:57 UTC

[GitHub] [incubator-kyuubi] ulysses-you opened a new pull request #1270: [KYUUBI #1269] Online documentation section in the readme is outdated

ulysses-you opened a new pull request #1270:
URL: https://github.com/apache/incubator-kyuubi/pull/1270


   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
     2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
   -->
   
   ### _Why are the changes needed?_
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about the use case of it.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   Closes https://github.com/apache/incubator-kyuubi/issues/1269
   
   ### _How was this patch tested?_
   docs only
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1270: [KYUUBI #1269] Online documentation section in the readme is outdated

Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1270:
URL: https://github.com/apache/incubator-kyuubi/pull/1270#discussion_r733347095



##########
File path: README.md
##########
@@ -96,19 +96,15 @@ The figure below shows our vision for the Kyuubi Ecosystem. Some of them have be
 Since Kyuubi 1.0.0, the Kyuubi online documentation is hosted by [https://readthedocs.org/](https://readthedocs.org/).
 You can find the specific version of Kyuubi documentation as listed below.
 
-- [master/latest](https://kyuubi.readthedocs.io/en/latest/)
-- [stable](https://kyuubi.readthedocs.io/en/stable/)
-- [v1.1.0](https://kyuubi.readthedocs.io/en/v1.1.0/)
-- [v1.0.3](https://kyuubi.readthedocs.io/en/v1.0.3/)
-- [v1.0.2](https://kyuubi.readthedocs.io/en/v1.0.2/)
-- [v1.0.1](https://kyuubi.readthedocs.io/en/v1.0.1/)
-- [v1.0.0](https://kyuubi.readthedocs.io/en/v1.0.0/)
+- [master/latest](https://kyuubi.apache.org/docs/latest/)

Review comment:
       It's not correct, the `https://kyuubi.apache.org/docs/latest/` point to the latest released doc. cc @turboFei for double confirm




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] ulysses-you closed pull request #1270: [KYUUBI #1269] Online documentation section in the readme is outdated

Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #1270:
URL: https://github.com/apache/incubator-kyuubi/pull/1270


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1270: [KYUUBI #1269] Online documentation section in the readme is outdated

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1270:
URL: https://github.com/apache/incubator-kyuubi/pull/1270#issuecomment-949282628


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1270](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4b15c2c) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/f0f065b983a15a577d21a3d39ae04dd7e12d058a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f0f065b) will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 4b15c2c differs from pull request most recent head 1cb99ef. Consider uploading reports for the commit 1cb99ef to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1270      +/-   ##
   ============================================
   - Coverage     78.30%   78.28%   -0.02%     
     Complexity      110      110              
   ============================================
     Files           176      176              
     Lines          6886     6886              
     Branches        843      843              
   ============================================
   - Hits           5392     5391       -1     
     Misses         1037     1037              
   - Partials        457      458       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `89.89% <0.00%> (-1.02%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f0f065b...1cb99ef](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] cfmcgrady commented on pull request #1270: [KYUUBI #1269] Online documentation section in the readme is outdated

Posted by GitBox <gi...@apache.org>.
cfmcgrady commented on pull request #1270:
URL: https://github.com/apache/incubator-kyuubi/pull/1270#issuecomment-948304828


   It seems we need to update the following links as well.
   ```shell
    [pr-1270] >grep readthedocs * -R                                                              
   README.md:[![Documentation Status](https://readthedocs.org/projects/kyuubi/badge/?version=latest)](https://kyuubi.apache.org/?badge=latest)
   README.md:Since Kyuubi 1.0.0, the Kyuubi online documentation is hosted by [https://readthedocs.org/](https://readthedocs.org/).
   README.md:- Improve Documentation - [![Documentation Status](https://readthedocs.org/projects/kyuubi/badge/?version=latest)](https://kyuubi.readthedocs.io/en/latest/?badge=latest)
   conf/kyuubi-defaults.conf.template:# Details in https://kyuubi.readthedocs.io/en/latest/deployment/settings.html
   docs/deployment/settings.md:# Details in https://kyuubi.readthedocs.io/en/latest/deployment/settings.html
   Binary file docs/_build/doctrees/deployment/settings.doctree matches
   Binary file docs/_build/doctrees/community/contributions.doctree matches
   Binary file docs/_build/doctrees/quick_start/quick_start_with_datagrip.doctree matches
   docs/community/contributions.md:     https://kyuubi.readthedocs.io/en/latest/community/contributions.html
   docs/community/contributions.md:- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   docs/quick_start/quick_start_with_helm.md:[Using Hive Beeline](https://kyuubi.readthedocs.io/en/latest/quick_start/quick_start.html#using-hive-beeline) to opening a connection.
   docs/quick_start/quick_start_with_datagrip.md:[Get kyuubi server started](https://kyuubi.readthedocs.io/en/latest/quick_start/quick_start.html) before you try DataGrip with kyuubi.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1270: [KYUUBI #1269] Online documentation section in the readme is outdated

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1270:
URL: https://github.com/apache/incubator-kyuubi/pull/1270#issuecomment-949282628


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1270](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4b15c2c) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/f0f065b983a15a577d21a3d39ae04dd7e12d058a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f0f065b) will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 4b15c2c differs from pull request most recent head 7a597e6. Consider uploading reports for the commit 7a597e6 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1270      +/-   ##
   ============================================
   - Coverage     78.30%   78.28%   -0.02%     
     Complexity      110      110              
   ============================================
     Files           176      176              
     Lines          6886     6886              
     Branches        843      843              
   ============================================
   - Hits           5392     5391       -1     
     Misses         1037     1037              
   - Partials        457      458       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `89.89% <0.00%> (-1.02%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f0f065b...7a597e6](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1270: [KYUUBI #1269] Online documentation section in the readme is outdated

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1270:
URL: https://github.com/apache/incubator-kyuubi/pull/1270#issuecomment-949282628


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1270](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1cb99ef) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/f0f065b983a15a577d21a3d39ae04dd7e12d058a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f0f065b) will **decrease** coverage by `0.06%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1270      +/-   ##
   ============================================
   - Coverage     78.30%   78.24%   -0.07%     
     Complexity      110      110              
   ============================================
     Files           176      177       +1     
     Lines          6886     6940      +54     
     Branches        843      852       +9     
   ============================================
   + Hits           5392     5430      +38     
   - Misses         1037     1042       +5     
   - Partials        457      468      +11     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...che/kyuubi/ha/client/ZooKeeperClientProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9ab29LZWVwZXJDbGllbnRQcm92aWRlci5zY2FsYQ==) | `70.17% <0.00%> (-11.88%)` | :arrow_down: |
   | [...ache/kyuubi/engine/spark/SparkProcessBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvc3BhcmsvU3BhcmtQcm9jZXNzQnVpbGRlci5zY2FsYQ==) | `86.86% <0.00%> (-2.91%)` | :arrow_down: |
   | [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `89.89% <0.00%> (-1.02%)` | :arrow_down: |
   | [...apache/kyuubi/ha/client/ZooKeeperACLProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9ab29LZWVwZXJBQ0xQcm92aWRlci5zY2FsYQ==) | `85.00% <0.00%> (-0.72%)` | :arrow_down: |
   | [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.22% <0.00%> (-0.02%)` | :arrow_down: |
   | [...g/apache/kyuubi/ha/client/ZooKeeperAuthTypes.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9ab29LZWVwZXJBdXRoVHlwZXMuc2NhbGE=) | `100.00% <0.00%> (ø)` | |
   | [...la/org/apache/kyuubi/ha/HighAvailabilityConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL0hpZ2hBdmFpbGFiaWxpdHlDb25mLnNjYWxh) | `98.85% <0.00%> (+0.32%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f0f065b...1cb99ef](https://codecov.io/gh/apache/incubator-kyuubi/pull/1270?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1270: [KYUUBI #1269] Online documentation section in the readme is outdated

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1270:
URL: https://github.com/apache/incubator-kyuubi/pull/1270#issuecomment-949282801


   thank you @pan3793 @cfmcgrady for the review, addressed comment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1270: [KYUUBI #1269] Online documentation section in the readme is outdated

Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1270:
URL: https://github.com/apache/incubator-kyuubi/pull/1270#discussion_r733347399



##########
File path: README.md
##########
@@ -96,19 +96,15 @@ The figure below shows our vision for the Kyuubi Ecosystem. Some of them have be
 Since Kyuubi 1.0.0, the Kyuubi online documentation is hosted by [https://readthedocs.org/](https://readthedocs.org/).

Review comment:
       Add *since 1.3.0-incubating ...*




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1270: [KYUUBI #1269] Online documentation section in the readme is outdated

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1270:
URL: https://github.com/apache/incubator-kyuubi/pull/1270#issuecomment-949282911


   aslo cc @aajisaka @yaooqinn @turboFei if you have time to take a look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] aajisaka commented on a change in pull request #1270: [KYUUBI #1269] Online documentation section in the readme is outdated

Posted by GitBox <gi...@apache.org>.
aajisaka commented on a change in pull request #1270:
URL: https://github.com/apache/incubator-kyuubi/pull/1270#discussion_r734234911



##########
File path: README.md
##########
@@ -93,29 +93,24 @@ The figure below shows our vision for the Kyuubi Ecosystem. Some of them have be
 
 ## Online Documentation
 
-Since Kyuubi 1.0.0, the Kyuubi online documentation is hosted by [https://readthedocs.org/](https://readthedocs.org/).
+Since Kyuubi 1.3.0-incubating, the Kyuubi online documentation is hosted by [https://kyuubi.apache.org/](https://kyuubi.apache.org/docs/latest/).
 You can find the specific version of Kyuubi documentation as listed below.
 
-- [master/latest](https://kyuubi.readthedocs.io/en/latest/)
-- [stable](https://kyuubi.readthedocs.io/en/stable/)
-- [v1.1.0](https://kyuubi.readthedocs.io/en/v1.1.0/)
-- [v1.0.3](https://kyuubi.readthedocs.io/en/v1.0.3/)
-- [v1.0.2](https://kyuubi.readthedocs.io/en/v1.0.2/)
-- [v1.0.1](https://kyuubi.readthedocs.io/en/v1.0.1/)
-- [v1.0.0](https://kyuubi.readthedocs.io/en/v1.0.0/)
+- [1.3.0-incubating](https://kyuubi.apache.org/docs/r1.3.0-incubating/)
+- [stable](https://kyuubi.apache.org/docs/stable/)
 
-For 0.8 and earlier versions, please check the [Github Pages](https://apache.github.io/incubator-kyuubi/) directly.
+For 1.2 and earlier versions, please check the [Github Pages](https://apache.github.io/incubator-kyuubi/) directly.

Review comment:
       I suppose the document of 1.2 and earlier versions are in https://kyuubi.readthedocs.io/en/v1.2.0/




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] aajisaka commented on a change in pull request #1270: [KYUUBI #1269] Online documentation section in the readme is outdated

Posted by GitBox <gi...@apache.org>.
aajisaka commented on a change in pull request #1270:
URL: https://github.com/apache/incubator-kyuubi/pull/1270#discussion_r734234911



##########
File path: README.md
##########
@@ -93,29 +93,24 @@ The figure below shows our vision for the Kyuubi Ecosystem. Some of them have be
 
 ## Online Documentation
 
-Since Kyuubi 1.0.0, the Kyuubi online documentation is hosted by [https://readthedocs.org/](https://readthedocs.org/).
+Since Kyuubi 1.3.0-incubating, the Kyuubi online documentation is hosted by [https://kyuubi.apache.org/](https://kyuubi.apache.org/docs/latest/).
 You can find the specific version of Kyuubi documentation as listed below.
 
-- [master/latest](https://kyuubi.readthedocs.io/en/latest/)
-- [stable](https://kyuubi.readthedocs.io/en/stable/)
-- [v1.1.0](https://kyuubi.readthedocs.io/en/v1.1.0/)
-- [v1.0.3](https://kyuubi.readthedocs.io/en/v1.0.3/)
-- [v1.0.2](https://kyuubi.readthedocs.io/en/v1.0.2/)
-- [v1.0.1](https://kyuubi.readthedocs.io/en/v1.0.1/)
-- [v1.0.0](https://kyuubi.readthedocs.io/en/v1.0.0/)
+- [1.3.0-incubating](https://kyuubi.apache.org/docs/r1.3.0-incubating/)
+- [stable](https://kyuubi.apache.org/docs/stable/)
 
-For 0.8 and earlier versions, please check the [Github Pages](https://apache.github.io/incubator-kyuubi/) directly.
+For 1.2 and earlier versions, please check the [Github Pages](https://apache.github.io/incubator-kyuubi/) directly.

Review comment:
       I suppose the document of 1.2 and earlier versions is in https://kyuubi.readthedocs.io/en/




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] aajisaka commented on a change in pull request #1270: [KYUUBI #1269] Online documentation section in the readme is outdated

Posted by GitBox <gi...@apache.org>.
aajisaka commented on a change in pull request #1270:
URL: https://github.com/apache/incubator-kyuubi/pull/1270#discussion_r734234911



##########
File path: README.md
##########
@@ -93,29 +93,24 @@ The figure below shows our vision for the Kyuubi Ecosystem. Some of them have be
 
 ## Online Documentation
 
-Since Kyuubi 1.0.0, the Kyuubi online documentation is hosted by [https://readthedocs.org/](https://readthedocs.org/).
+Since Kyuubi 1.3.0-incubating, the Kyuubi online documentation is hosted by [https://kyuubi.apache.org/](https://kyuubi.apache.org/docs/latest/).
 You can find the specific version of Kyuubi documentation as listed below.
 
-- [master/latest](https://kyuubi.readthedocs.io/en/latest/)
-- [stable](https://kyuubi.readthedocs.io/en/stable/)
-- [v1.1.0](https://kyuubi.readthedocs.io/en/v1.1.0/)
-- [v1.0.3](https://kyuubi.readthedocs.io/en/v1.0.3/)
-- [v1.0.2](https://kyuubi.readthedocs.io/en/v1.0.2/)
-- [v1.0.1](https://kyuubi.readthedocs.io/en/v1.0.1/)
-- [v1.0.0](https://kyuubi.readthedocs.io/en/v1.0.0/)
+- [1.3.0-incubating](https://kyuubi.apache.org/docs/r1.3.0-incubating/)
+- [stable](https://kyuubi.apache.org/docs/stable/)
 
-For 0.8 and earlier versions, please check the [Github Pages](https://apache.github.io/incubator-kyuubi/) directly.
+For 1.2 and earlier versions, please check the [Github Pages](https://apache.github.io/incubator-kyuubi/) directly.

Review comment:
       I suppose the document of 1.2 and earlier versions are in https://kyuubi.readthedocs.io/en/




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1270: [KYUUBI #1269] Online documentation section in the readme is outdated

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1270:
URL: https://github.com/apache/incubator-kyuubi/pull/1270#issuecomment-949321742


   thank you all for the reivew ! merging to master/branch-1.3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1270: [KYUUBI #1269] Online documentation section in the readme is outdated

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1270:
URL: https://github.com/apache/incubator-kyuubi/pull/1270#discussion_r734272204



##########
File path: docs/community/contributions.md
##########
@@ -79,6 +79,6 @@ Please clarify why the changes are needed. For instance,
 
 - [ ] Add screenshots for manual tests if appropriate
 
-- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
+- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Review comment:
       this PR template is also outdated




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org