[GitHub] [skywalking] wu-sheng commented on a change in pull request #2601: Add catch clause more details.

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #2601: Add catch clause more details.
URL: https://github.com/apache/skywalking/pull/2601#discussion_r281070718
 
 

 ##########
 File path: apm-sniffer/apm-agent/src/main/java/org/apache/skywalking/apm/agent/SkyWalkingAgent.java
 ##########
 @@ -61,6 +63,12 @@ public static void premain(String agentArgs, Instrumentation instrumentation) th
 
             pluginFinder = new PluginFinder(new PluginBootstrap().loadPlugins());
 
+        } catch (ConfigNotFoundException ce) {
+            logger.error(ce, "Skywalking agent could not find config. Shutting down.");
+            return;
+        } catch (AgentPackageNotFoundException ape) {
+            logger.error(ape, "Skywalking agent is missing agent-core library. Shutting down.");
 
 Review comment:
   I think this log should be
   
   > Locate agent.jar failure. Shutting down.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services