You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by manasaveloori <gi...@git.apache.org> on 2015/08/13 07:32:07 UTC

[GitHub] cloudstack pull request: verify that when createTemplate is ued to...

GitHub user manasaveloori opened a pull request:

    https://github.com/apache/cloudstack/pull/688

    verify that when createTemplate is ued to create templates with same …

    …name,
    
    all of them fet unique_name under vm_template table so that templates with
    same name does not get deleted during template sync

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/manasaveloori/cloudstack Test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/688.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #688
    
----
commit ab8b2af13cfb93458e77102b4177ffa3e86df146
Author: manasaVeloori <ma...@gmail.com>
Date:   2015-08-13T05:26:18Z

    verify that when createTemplate is ued to create templates with same name,
    all of them fet unique_name under vm_template table so that templates with
    same name does not get deleted during template sync

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] cloudstack pull request: verify that when createTemplate is ued to...

Posted by Sanjeev N <sa...@apache.org>.
LGTM!!

On Wed, Aug 26, 2015 at 3:01 PM, bhaisaab <gi...@git.apache.org> wrote:

> Github user bhaisaab commented on the pull request:
>
>     https://github.com/apache/cloudstack/pull/688#issuecomment-134918074
>
>     LGTM
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] cloudstack pull request: verify that when createTemplate is ued to...

Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/688#issuecomment-134918074
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: verify that when createTemplate is ued to...

Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/688#issuecomment-134983872
  
    Sanjeev, thanks! Can you please use the git merge script located in ./tools/git/git-pr? See: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61311655
    Let me know if you need help. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: verify that when createTemplate is ued to...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/688


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: verify that when createTemplate is ued to...

Posted by manasaveloori <gi...@git.apache.org>.
Github user manasaveloori commented on the pull request:

    https://github.com/apache/cloudstack/pull/688#issuecomment-130540793
  
    Test when createTemplate is used to create templates having the same name all of them get ... === TestName: test_CreateTemplateWithDuplicateName | Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 1 test in 442.896s
    
    OK


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: verify that when createTemplate is ued to...

Posted by nitt10prashant <gi...@git.apache.org>.
Github user nitt10prashant commented on the pull request:

    https://github.com/apache/cloudstack/pull/688#issuecomment-134972409
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---