[GitHub] [lucene-solr] dweiss commented on a change in pull request #2351: LUCENE-9763: Hunspell: fix FORBIDDENWORD support

[GitBox <gi...@apache.org>]

dweiss commented on a change in pull request #2351:
URL: https://github.com/apache/lucene-solr/pull/2351#discussion_r574532355



##########
File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java
##########
@@ -51,22 +51,22 @@
   }
 
   List<String> suggest(String word, WordCase originalCase, Set<String> prevSuggestions) {
-    List<Weighted<DictEntry>> roots = findSimilarDictionaryEntries(word, originalCase);
+    List<Weighted<Root<String>>> roots = findSimilarDictionaryEntries(word, originalCase);

Review comment:
       Thanks, these comment help a lot.

##########
File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Stemmer.java
##########
@@ -94,10 +93,6 @@ public Stemmer(Dictionary dictionary) {
       word = scratchBuffer;
     }
 
-    if (dictionary.isForbiddenWord(word, length)) {

Review comment:
       Hmmm... shouldn't this be reported as a bug to hunspell though?

##########
File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestDutchIJ.java
##########
@@ -27,6 +27,5 @@ public static void beforeClass() throws Exception {
   public void testStemming() {
     assertStemsTo("ijs", "ijs");
     assertStemsTo("IJs", "ijs");
-    assertStemsTo("Ijs");

Review comment:
       Ok.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org