You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "orpiske (via GitHub)" <gi...@apache.org> on 2023/07/18 14:37:55 UTC
[GitHub] [camel] orpiske opened a new pull request, #10717: (chores) camel-dhis: fixed remaining incorrect logging
orpiske opened a new pull request, #10717:
URL: https://github.com/apache/camel/pull/10717
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10717: CAMEL-19568: disable header validation on camel-netty-http
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10717:
URL: https://github.com/apache/camel/pull/10717#issuecomment-1641985015
The failure is unrelated to this change. Let's merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10717: (chores) camel-dhis: fixed remaining incorrect logging
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10717:
URL: https://github.com/apache/camel/pull/10717#issuecomment-1640355752
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
:robot: Use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10717: CAMEL-19568: disable header validation on camel-netty-http
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10717:
URL: https://github.com/apache/camel/pull/10717#issuecomment-1640379907
> This will open us to CVE weakness. From http response splitting to other stuff. Validation should be always enabled
Oh, BTW, this applies to the validation of responses only. That is: the responses Camel is sending ... not those it is consuming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10717: CAMEL-19568: disable header validation on camel-netty-http
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10717:
URL: https://github.com/apache/camel/pull/10717#issuecomment-1641653544
> > > This will open us to CVE weakness. From http response splitting to other stuff. Validation should be always enabled
> >
> >
> > Oh, BTW, this applies to the validation of responses only. That is: the responses Camel is sending ... not those it is consuming.
>
> I didn't notice this
Ahhh, cool. Thanks for double checking.
Obs.: there are some tests failing, so I'll review that before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10717: CAMEL-19568: disable header validation on camel-netty-http
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10717:
URL: https://github.com/apache/camel/pull/10717#issuecomment-1640377232
> This will open us to CVE weakness. From http response splitting to other stuff. Validation should be always enabled
That's a good point 🤔
Any suggestions how we could possibly work-around the original issue? One idea I had (which I scrapped) was to change the code like from:
```
response.headers().set(HttpHeaderNames.CONTENT_TYPE.toString(), contentType);
```
To:
```
response.headers().set(HttpHeaderNames.CONTENT_TYPE.toString(), contentType.replace("\r\n\t", "");
```
wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #10717: CAMEL-19568: disable header validation on camel-netty-http
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #10717:
URL: https://github.com/apache/camel/pull/10717#issuecomment-1640537762
> > This will open us to CVE weakness. From http response splitting to other stuff. Validation should be always enabled
>
> Oh, BTW, this applies to the validation of responses only. That is: the responses Camel is sending ... not those it is consuming.
I didn't notice this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske merged pull request #10717: CAMEL-19568: disable header validation on camel-netty-http
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske merged PR #10717:
URL: https://github.com/apache/camel/pull/10717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org