You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2020/03/26 22:59:07 UTC
[kudu-CR] [ranger] add more comments for Ranger privilege model
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15566
Change subject: [ranger] add more comments for Ranger privilege model
......................................................................
[ranger] add more comments for Ranger privilege model
Change-Id: I1b827d06c7657e450903333d820dc9ef9313dcd6
---
M src/kudu/master/ranger_authz_provider.h
M src/kudu/ranger/ranger.proto
M src/kudu/ranger/ranger_client.h
3 files changed, 31 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/15566/1
--
To view, visit http://gerrit.cloudera.org:8080/15566
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b827d06c7657e450903333d820dc9ef9313dcd6
Gerrit-Change-Number: 15566
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[kudu-CR] [ranger] add more comments for Ranger privilege model
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15566 )
Change subject: [ranger] add more comments for Ranger privilege model
......................................................................
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/15566/1/src/kudu/ranger/ranger.proto
File src/kudu/ranger/ranger.proto:
http://gerrit.cloudera.org:8080/#/c/15566/1/src/kudu/ranger/ranger.proto@23
PS1, Line 23: →
nit: We should prefer ASCII characters where we don't need to use UTF-8
http://gerrit.cloudera.org:8080/#/c/15566/1/src/kudu/ranger/ranger.proto@32
PS1, Line 32: .
nit: Should be a comma instead.
http://gerrit.cloudera.org:8080/#/c/15566/1/src/kudu/ranger/ranger.proto@33
PS1, Line 33: DATABSE
nit: DATABASE
http://gerrit.cloudera.org:8080/#/c/15566/1/src/kudu/ranger/ranger.proto@35
PS1, Line 35: DATABSE
nit: DATABASE
http://gerrit.cloudera.org:8080/#/c/15566/1/src/kudu/ranger/ranger_client.h
File src/kudu/ranger/ranger_client.h:
http://gerrit.cloudera.org:8080/#/c/15566/1/src/kudu/ranger/ranger_client.h@55
PS1, Line 55: →
nit: We should stick to ASCII characters wherever we can.
http://gerrit.cloudera.org:8080/#/c/15566/1/src/kudu/ranger/ranger_client.h@58
PS1, Line 58: it is not
: // used yet
Can you elaborate on this? We do use column level privileges in FillTablePrivilegePB.
--
To view, visit http://gerrit.cloudera.org:8080/15566
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b827d06c7657e450903333d820dc9ef9313dcd6
Gerrit-Change-Number: 15566
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 27 Mar 2020 19:56:50 +0000
Gerrit-HasComments: Yes
[kudu-CR] [ranger] add more comments for Ranger privilege model
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15566 )
Change subject: [ranger] add more comments for Ranger privilege model
......................................................................
Patch Set 2:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/15566/2/src/kudu/ranger/ranger.proto
File src/kudu/ranger/ranger.proto:
http://gerrit.cloudera.org:8080/#/c/15566/2/src/kudu/ranger/ranger.proto@30
PS2, Line 30: which
where
http://gerrit.cloudera.org:8080/#/c/15566/2/src/kudu/ranger/ranger.proto@30
PS2, Line 30: which authorizables higher
: // up on the hierarchy can imply authorizables lower on the hierarchy, e.g.
: // database implies table,
Nit: I'd move this into parentheses to improve the readability of the sentence.
http://gerrit.cloudera.org:8080/#/c/15566/2/src/kudu/ranger/ranger.proto@34
PS2, Line 34: cannot
does not
http://gerrit.cloudera.org:8080/#/c/15566/2/src/kudu/ranger/ranger.proto@35
PS2, Line 35: authorizable
an authorizable
http://gerrit.cloudera.org:8080/#/c/15566/2/src/kudu/ranger/ranger.proto@38
PS2, Line 38: actaully
actually
http://gerrit.cloudera.org:8080/#/c/15566/2/src/kudu/ranger/ranger.proto@39
PS2, Line 39: with
Nit: replace with "the semantics of"
--
To view, visit http://gerrit.cloudera.org:8080/15566
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b827d06c7657e450903333d820dc9ef9313dcd6
Gerrit-Change-Number: 15566
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 28 Mar 2020 00:20:42 +0000
Gerrit-HasComments: Yes
[kudu-CR] [ranger] add more comments for Ranger privilege model
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15566
to look at the new patch set (#4).
Change subject: [ranger] add more comments for Ranger privilege model
......................................................................
[ranger] add more comments for Ranger privilege model
Change-Id: I1b827d06c7657e450903333d820dc9ef9313dcd6
---
M src/kudu/master/ranger_authz_provider.h
M src/kudu/ranger/ranger.proto
M src/kudu/ranger/ranger_client.h
3 files changed, 32 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/15566/4
--
To view, visit http://gerrit.cloudera.org:8080/15566
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1b827d06c7657e450903333d820dc9ef9313dcd6
Gerrit-Change-Number: 15566
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [ranger] add more comments for Ranger privilege model
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15566 )
Change subject: [ranger] add more comments for Ranger privilege model
......................................................................
Patch Set 3: Code-Review+1
(5 comments)
http://gerrit.cloudera.org:8080/#/c/15566/3/src/kudu/ranger/ranger.proto
File src/kudu/ranger/ranger.proto:
http://gerrit.cloudera.org:8080/#/c/15566/3/src/kudu/ranger/ranger.proto@21
PS3, Line 21: action is
nit: "an action is an operation"
http://gerrit.cloudera.org:8080/#/c/15566/3/src/kudu/ranger/ranger.proto@22
PS3, Line 22: authorizable is linear hierarchical structured resource
nit: "an authorizable is a linear hierarchically structured resource"
http://gerrit.cloudera.org:8080/#/c/15566/3/src/kudu/ranger/ranger.proto@23
PS3, Line 23: olumn). And privileges a
nit: "column), and 'privileges' are"
http://gerrit.cloudera.org:8080/#/c/15566/3/src/kudu/ranger/ranger.proto@24
PS3, Line 24: a
nit: maybe "db" or "db=a" so it's more obvious this is the database name
http://gerrit.cloudera.org:8080/#/c/15566/3/src/kudu/ranger/ranger.proto@35
PS3, Line 35: cannot access an authorizable
I think you mean they can't perform an action that requires that privilege, right?
--
To view, visit http://gerrit.cloudera.org:8080/15566
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b827d06c7657e450903333d820dc9ef9313dcd6
Gerrit-Change-Number: 15566
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 28 Mar 2020 04:03:42 +0000
Gerrit-HasComments: Yes
[kudu-CR] [ranger] add more comments for Ranger privilege model
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15566 )
Change subject: [ranger] add more comments for Ranger privilege model
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15566
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b827d06c7657e450903333d820dc9ef9313dcd6
Gerrit-Change-Number: 15566
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 30 Mar 2020 05:51:48 +0000
Gerrit-HasComments: No
[kudu-CR] [ranger] add more comments for Ranger privilege model
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15566 )
Change subject: [ranger] add more comments for Ranger privilege model
......................................................................
Patch Set 3:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/15566/3/src/kudu/ranger/ranger.proto
File src/kudu/ranger/ranger.proto:
http://gerrit.cloudera.org:8080/#/c/15566/3/src/kudu/ranger/ranger.proto@21
PS3, Line 21: action is
> nit: "an action is an operation"
Done
http://gerrit.cloudera.org:8080/#/c/15566/3/src/kudu/ranger/ranger.proto@22
PS3, Line 22: authorizable is linear hierarchical structured resource
> nit: "an authorizable is a linear hierarchically structured resource"
Done
http://gerrit.cloudera.org:8080/#/c/15566/3/src/kudu/ranger/ranger.proto@23
PS3, Line 23: olumn). And privileges a
> nit: "column), and 'privileges' are"
Done
http://gerrit.cloudera.org:8080/#/c/15566/3/src/kudu/ranger/ranger.proto@24
PS3, Line 24: a
> nit: maybe "db" or "db=a" so it's more obvious this is the database name
Done
http://gerrit.cloudera.org:8080/#/c/15566/3/src/kudu/ranger/ranger.proto@35
PS3, Line 35: cannot access an authorizable
> I think you mean they can't perform an action that requires that privilege,
yeah. Updated.
--
To view, visit http://gerrit.cloudera.org:8080/15566
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b827d06c7657e450903333d820dc9ef9313dcd6
Gerrit-Change-Number: 15566
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 29 Mar 2020 21:32:42 +0000
Gerrit-HasComments: Yes
[kudu-CR] [ranger] add more comments for Ranger privilege model
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15566 )
Change subject: [ranger] add more comments for Ranger privilege model
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15566
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b827d06c7657e450903333d820dc9ef9313dcd6
Gerrit-Change-Number: 15566
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 28 Mar 2020 01:03:35 +0000
Gerrit-HasComments: No
[kudu-CR] [ranger] add more comments for Ranger privilege model
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15566 )
Change subject: [ranger] add more comments for Ranger privilege model
......................................................................
Patch Set 2:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/15566/2/src/kudu/ranger/ranger.proto
File src/kudu/ranger/ranger.proto:
http://gerrit.cloudera.org:8080/#/c/15566/2/src/kudu/ranger/ranger.proto@30
PS2, Line 30: which
> where
Done
http://gerrit.cloudera.org:8080/#/c/15566/2/src/kudu/ranger/ranger.proto@30
PS2, Line 30: which authorizables higher
: // up on the hierarchy can imply authorizables lower on the hierarchy, e.g.
: // database implies table,
> Nit: I'd move this into parentheses to improve the readability of the sente
Done
http://gerrit.cloudera.org:8080/#/c/15566/2/src/kudu/ranger/ranger.proto@34
PS2, Line 34: cannot
> does not
Done
http://gerrit.cloudera.org:8080/#/c/15566/2/src/kudu/ranger/ranger.proto@35
PS2, Line 35: authorizable
> an authorizable
Done
http://gerrit.cloudera.org:8080/#/c/15566/2/src/kudu/ranger/ranger.proto@38
PS2, Line 38: actaully
> actually
Done
http://gerrit.cloudera.org:8080/#/c/15566/2/src/kudu/ranger/ranger.proto@39
PS2, Line 39: with
> Nit: replace with "the semantics of"
Done
--
To view, visit http://gerrit.cloudera.org:8080/15566
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b827d06c7657e450903333d820dc9ef9313dcd6
Gerrit-Change-Number: 15566
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 28 Mar 2020 00:41:37 +0000
Gerrit-HasComments: Yes
[kudu-CR] [ranger] add more comments for Ranger privilege model
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15566
to look at the new patch set (#3).
Change subject: [ranger] add more comments for Ranger privilege model
......................................................................
[ranger] add more comments for Ranger privilege model
Change-Id: I1b827d06c7657e450903333d820dc9ef9313dcd6
---
M src/kudu/master/ranger_authz_provider.h
M src/kudu/ranger/ranger.proto
M src/kudu/ranger/ranger_client.h
3 files changed, 32 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/15566/3
--
To view, visit http://gerrit.cloudera.org:8080/15566
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1b827d06c7657e450903333d820dc9ef9313dcd6
Gerrit-Change-Number: 15566
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [ranger] add more comments for Ranger privilege model
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15566 )
Change subject: [ranger] add more comments for Ranger privilege model
......................................................................
Patch Set 2:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/15566/1/src/kudu/ranger/ranger.proto
File src/kudu/ranger/ranger.proto:
http://gerrit.cloudera.org:8080/#/c/15566/1/src/kudu/ranger/ranger.proto@23
PS1, Line 23: -
> nit: We should prefer ASCII characters where we don't need to use UTF-8
Done
http://gerrit.cloudera.org:8080/#/c/15566/1/src/kudu/ranger/ranger.proto@32
PS1, Line 32: ,
> nit: Should be a comma instead.
Done
http://gerrit.cloudera.org:8080/#/c/15566/1/src/kudu/ranger/ranger.proto@33
PS1, Line 33: DATABAS
> nit: DATABASE
Done
http://gerrit.cloudera.org:8080/#/c/15566/1/src/kudu/ranger/ranger.proto@35
PS1, Line 35: DATABAS
> nit: DATABASE
Done
http://gerrit.cloudera.org:8080/#/c/15566/1/src/kudu/ranger/ranger_client.h
File src/kudu/ranger/ranger_client.h:
http://gerrit.cloudera.org:8080/#/c/15566/1/src/kudu/ranger/ranger_client.h@55
PS1, Line 55: -
> nit: We should stick to ASCII characters wherever we can.
Done
http://gerrit.cloudera.org:8080/#/c/15566/1/src/kudu/ranger/ranger_client.h@58
PS1, Line 58: it is not
: // used yet
> Can you elaborate on this? We do use column level privileges in FillTablePr
Sorry for the confusion, I mean the COLUMN enum is not used, however the concept still apply.
--
To view, visit http://gerrit.cloudera.org:8080/15566
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b827d06c7657e450903333d820dc9ef9313dcd6
Gerrit-Change-Number: 15566
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 27 Mar 2020 21:02:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] [ranger] add more comments for Ranger privilege model
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15566 )
Change subject: [ranger] add more comments for Ranger privilege model
......................................................................
[ranger] add more comments for Ranger privilege model
Change-Id: I1b827d06c7657e450903333d820dc9ef9313dcd6
Reviewed-on: http://gerrit.cloudera.org:8080/15566
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/master/ranger_authz_provider.h
M src/kudu/ranger/ranger.proto
M src/kudu/ranger/ranger_client.h
3 files changed, 32 insertions(+), 20 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15566
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b827d06c7657e450903333d820dc9ef9313dcd6
Gerrit-Change-Number: 15566
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [ranger] add more comments for Ranger privilege model
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15566 )
Change subject: [ranger] add more comments for Ranger privilege model
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15566
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b827d06c7657e450903333d820dc9ef9313dcd6
Gerrit-Change-Number: 15566
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 28 Mar 2020 12:55:49 +0000
Gerrit-HasComments: No
[kudu-CR] [ranger] add more comments for Ranger privilege model
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15566
to look at the new patch set (#2).
Change subject: [ranger] add more comments for Ranger privilege model
......................................................................
[ranger] add more comments for Ranger privilege model
Change-Id: I1b827d06c7657e450903333d820dc9ef9313dcd6
---
M src/kudu/master/ranger_authz_provider.h
M src/kudu/ranger/ranger.proto
M src/kudu/ranger/ranger_client.h
3 files changed, 32 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/15566/2
--
To view, visit http://gerrit.cloudera.org:8080/15566
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1b827d06c7657e450903333d820dc9ef9313dcd6
Gerrit-Change-Number: 15566
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [ranger] add more comments for Ranger privilege model
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15566 )
Change subject: [ranger] add more comments for Ranger privilege model
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/15566
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b827d06c7657e450903333d820dc9ef9313dcd6
Gerrit-Change-Number: 15566
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 27 Mar 2020 21:34:08 +0000
Gerrit-HasComments: No