[jira] [Commented] (HADOOP-8228) Auto HA: Refactor tests and add stress tests

["Aaron T. Myers (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-8228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242643#comment-13242643 ] 

Aaron T. Myers commented on HADOOP-8228:
----------------------------------------

This is some great cleanup, Todd. The new test/testing API look good.

One question: are you positive that the ordering of the two @After methods either doesn't matter, or is guaranteed to happen in the right order?

One comment: maybe use a deterministic random seed for the Random instances you're using? Or at least log the amount of time that the test is sleeping for and what it's throwing? I realize that the test won't be deterministic regardless, but it will be really tough to try to reproduce test failures caused by a particular ZK disconnect pattern or health check failure pattern if we have no idea what that pattern was.

+1 once those are addressed
                
> Auto HA: Refactor tests and add stress tests
> --------------------------------------------
>
>                 Key: HADOOP-8228
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8228
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: auto-failover, ha, test
>    Affects Versions: Auto Failover (HDFS-3042)
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-8228.txt, hadoop-8228.txt, hadoop-8228.txt
>
>
> It's important that the ZKFailoverController be robust and not contain race conditions, etc. One strategy to find potential races is to add stress tests which exercise the code as fast as possible. This JIRA is to implement some test cases of this style.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira