[GitHub] [iceberg] rdblue commented on pull request #7750: Core: Move UpdateRequirement out of rest package

["rdblue (via GitHub)" <gi...@apache.org>]

rdblue commented on PR #7750:
URL: https://github.com/apache/iceberg/pull/7750#issuecomment-1588274596

   @nastra, this is looking really close. I think the only issue is validating that the assertions are created correctly from the base table state, not just that the correct type of requirements are created. I guess this was being tested before by the REST catalog tests since these were embedded, but now that this is stand-alone logic I'd prefer to finish the tests. Also, we should make sure that there are tests for all of the paths in `UpdateRequirements` including when requirements are omitted because the table state has already changed (for example, two `SetCurrentSchema` updates).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org