[GitHub] incubator-zeppelin issue #973: [ZEPPELIN-973, ZEPPELIN-954] Table rendering ...

[corneadoug <gi...@git.apache.org>]

Github user corneadoug commented on the issue:

    https://github.com/apache/incubator-zeppelin/pull/973
  
    @jasonxh Thanks for the fix
    Next time if possible, please add a simple code example for testing, like:
    ```
    print(s"""%table
    name\tsize
    sun\t127.6
    moon\t0.6458
    gerard\t45.234856803""")
    ```
    It can save a lot of time to the reviewer :)
    
    I tested and the decimal formating is working great, HTML and string rendering is still good too.
    
    Regarding the selection cell for copy, I would advise to use both:
    ```
    fragmentSelection: true,
    disableVisualSelection: true,
    ```
    
    This would remove the cell selection (with the border), and allow selection of the table text visually.
    ![screen shot 2016-06-08 at 2 36 59 pm](https://cloud.githubusercontent.com/assets/710411/15883785/7c5af448-2d86-11e6-9565-bcc30c29877f.png)
    
    So except for that small configuration change, LGTM



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---