[GitHub] [sedona] jiayuasu commented on a diff in pull request #887: [SEDONA-303] Port all Sedona Spark functions to Sedona Flink -- Step 4

["jiayuasu (via GitHub)" <gi...@apache.org>]

jiayuasu commented on code in PR #887:
URL: https://github.com/apache/sedona/pull/887#discussion_r1255137234


##########
docs/api/sql/Function.md:
##########
@@ -1552,18 +1552,18 @@ SELECT ST_AsText(ST_PointOnSurface(ST_GeomFromText('LINESTRING(0 5 1, 0 0 1, 0 1
 
 ```
 
-## ST_PrecisionReduce
+## ST_ReducePrecision
 
 Introduction: Reduce the decimals places in the coordinates of the geometry to the given number of decimal places. The last decimal place will be rounded.
 
-Format: `ST_PrecisionReduce (A:geometry, B:int)`

Review Comment:
   Please add one more sentence saying that the name of this function was called ST_PrecisionReduce in versions prior to v1.5.0.



##########
sql/common/src/main/scala/org/apache/sedona/sql/UDF/Catalog.scala:
##########
@@ -102,7 +102,7 @@ object Catalog {
     function[ST_ClosestPoint](),
     function[ST_Boundary](),
     function[ST_MinimumBoundingRadius](),
-    function[ST_MinimumBoundingCircle](BufferParameters.DEFAULT_QUADRANT_SEGMENTS),

Review Comment:
   Please update the doc in Sedona Spark saying that the default param has been changed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org