You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/23 01:09:54 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #7812: Imrrove support for latest API in MLEngineStartTrainingJobOperator

mik-laj commented on a change in pull request #7812: Imrrove support for latest API in  MLEngineStartTrainingJobOperator
URL: https://github.com/apache/airflow/pull/7812#discussion_r396172934
 
 

 ##########
 File path: airflow/providers/google/cloud/operators/mlengine.py
 ##########
 @@ -1027,8 +1027,16 @@ def execute(self, context):
         # Helper method to check if the existing job's training input is the
         # same as the request we get here.
         def check_existing_job(existing_job):
-            return existing_job.get('trainingInput', None) == \
-                training_request['trainingInput']
+            existing_training_input = existing_job.get('trainingInput', None)
+            requested_training_input = training_request['trainingInput']
+            if 'scaleTier' not in existing_training_input:
+                existing_training_input['scaleTier'] = None
 
 Review comment:
   The API has stopped returning fields that are empty.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services