You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jscheffl (via GitHub)" <gi...@apache.org> on 2024/11/01 14:48:15 UTC
[PR] Fix Try Selector in Mapped Tasks also on Index 0 [airflow]
jscheffl opened a new pull request, #43590:
URL: https://github.com/apache/airflow/pull/43590
While doing a regression on release tests on 2.10.3rc2 I noticed that the fixed logic still has a problem on mapped in dex 0 - seem I did not click on the first mapped element when testing :-(
This PR fixes the logic such that the try history is correctly fetched also for index 0 if dynamic mapped tasks.
Hope we get rid of this code in Airflow 3, this manual client function is really error prone.
related: #43565 #42357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Try Selector in Mapped Tasks also on Index 0 [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #43590:
URL: https://github.com/apache/airflow/pull/43590#discussion_r1826077678
##########
airflow/www/static/js/api/useTIHistory.ts:
##########
@@ -48,7 +48,7 @@ export default function useTIHistory({
.replace("_DAG_RUN_ID_", dagRunId)
.replace("_TASK_ID_", taskId);
- if (mapIndex && mapIndex > -1) {
+ if (typeof mapIndex !== "undefined" && mapIndex > -1) {
Review Comment:
```suggestion
if (mapIndex !== undefined && mapIndex > -1) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Try Selector in Mapped Tasks also on Index 0 [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl closed pull request #43590: Fix Try Selector in Mapped Tasks also on Index 0
URL: https://github.com/apache/airflow/pull/43590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Try Selector in Mapped Tasks also on Index 0 [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl merged PR #43590:
URL: https://github.com/apache/airflow/pull/43590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org